| Summary: | Offer a user-adjustable padding/margin setting for widgets that have internal padding | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Steeven Hudon <styvn> |
| Component: | QStyle | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
| Status: | CONFIRMED --- | ||
| Severity: | wishlist | CC: | akontsevich, hotmusicfan, maty78485, nate, uhhadd |
| Priority: | NOR | ||
| Version: | 5.18.3 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Steeven Hudon
2020-03-16 01:25:19 UTC
In general we try to avoid this kind of super-granular setting; it's why different themes exist, after all. :) But can you clarify what you mean by "padding"? The size of the elements themselves? The amount of whitespace between them? Etc. And maybe provide a mockup of what you would like to change it to, if you had such an option? Here are my answers to your comments : In general we try to avoid this kind of super-granular setting; it's why different themes exist, after all. // I totally understand :). However, I can't seem to be able to modify the padding in the theme files, as Breeze is a complete engine, compared to a Kvantum or a GTK theme for example. But can you clarify what you mean by "padding" // For example, on a button, the space between the text on top of the button and the border of the button. Sometimes, the horizontal and vertical paddings are different. Maybe provide a mockup of what you would like to change it to, if you had such an option // I seek a way to have a more compact look while keeping the awesome Breeze look. As an example, there is such a feature in Outook to use less space and a much tighter look (see https://support.office.com/en-us/article/prefer-tighter-spacing-7aedcfaf-03de-49ad-9bf8-8730134f1f3b). To give you an idea, see image here https://gxcuf89792.i.lithium.com/t5/image/serverpage/image-id/116555i4263507EC76AF388?v=1.0. Let me know if you need more info. Thanks. I still feel a bit wary about this, but we do keep getting people asking for either more or less padding, so there does appear to be some user demand. *** Bug 382740 has been marked as a duplicate of this bug. *** *** Bug 371489 has been marked as a duplicate of this bug. *** Consensus from our designers seems to be that we don't want this as an option, so I'm marking as RESOLVED INTENTIONAL for now. Actually I think a variant of this idea makes a lot of sense for Tablet Mode. When you're in Tablet Mode you generally want short things to be taller and (more rarely) narrow things to be wider, to better match the dimensions of a human finger. Currently we mostly handle this in Kirigami by making things taller in tablet mode. But we could do it in the QStyle to make this convention apply to QtWidgets apps as well. Such a thing could indeed be implemented the way it's proposed here. Once we have code for that, it shouldn't be too hard to let users manually toggle it base don their preferred density. Git commit 3fe906b0bc687b57961f61e9a7a6a00f270fd9ce by Nate Graham, on behalf of Marco Martin. Committed on 30/03/2022 at 14:19. Pushed by ngraham into branch 'master'. Adapt UI elements' sizes when in Tablet Mode Now interactive UI elements get bigger when in Tablet mode, and return to normal size when out of it. This is automatic, and currently there is no UI to manually control it. Sending a stylechanged event makes everything to be reevaluated but the style instance doesn't get actually reloaded, so this is still manageable, resource-wise. M +28 -0 kstyle/breezemetrics.h M +156 -52 kstyle/breezestyle.cpp M +3 -0 kstyle/breezestyle.h https://invent.kde.org/plasma/breeze/commit/3fe906b0bc687b57961f61e9a7a6a00f270fd9ce |