Summary: | URL special chars such as '#' not handle properly. | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Fabian Vogt <fabian> |
Component: | Open/save dialogs | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, kdelibs-bugs, nate |
Priority: | NOR | ||
Version: | 5.67.0 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kio/commit/f29ce254864ce575d12717896edcf71b35c2a30a | Version Fixed In: | 5.76 |
Description
Fabian Vogt
2020-03-10 16:02:36 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/178 Git commit f29ce254864ce575d12717896edcf71b35c2a30a by Ahmad Samir. Committed on 22/10/2020 at 09:01. Pushed by dfaure into branch 'master'. kfilewidget: keep the text in the Name box when navigating In _k_urlEntered, if keepLocation is true (which it is in e.g. Saving mode), KComboBox::changeUrl() was called to update the item in the Name KUrlComboBox, AFAIU this is mainly to show the icon of the mimetype of the file in the KComboBox. One issue with that approach is that if the user types "some#file" and then goes up (i.e. navigate in the view) the text will change to "some%23file", the, '#' is encoded to %23, then going up again will encode "%" to '%25', and the text becomes "some%2523file"... etc. Replace changeUrl() with KComboBox::setItemIcon(), this way the icon is updated and the text typed by the user is kept as-is. The same logic is used through out code (e.g. setDummyHistoryEntry). Unit test written by dfaure. FIXED-IN: 5.76 M +26 -0 autotests/kfilewidgettest.cpp M +4 -4 src/filewidgets/kfilewidget.cpp https://invent.kde.org/frameworks/kio/commit/f29ce254864ce575d12717896edcf71b35c2a30a *** Bug 426485 has been marked as a duplicate of this bug. *** |