Bug 418668

Summary: Color selector pop up menu issue
Product: [Applications] krita Reporter: grzegorzpedrycz
Component: Color SelectorsAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: ahab.greybeard, halla, lynx.mw+kde
Priority: NOR Keywords: regression
Version: 4.2.9-beta1   
Target Milestone: ---   
Platform: Other   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Attachments: Color selector menu issue

Description grzegorzpedrycz 2020-03-09 12:56:38 UTC
Created attachment 126699 [details]
Color selector  menu issue

SUMMARY

When you use color selector pop up menu ("Show color selector " ) and you  drag colorpicker point  to the edge of color box , menu is turning off. You cant take a colors from the edge of box . I mean you can but it frustrating and hard. One small mistake and menu is turning off.. . I show that situation in attached gif 
 



SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 grzegorzpedrycz 2020-03-09 12:58:33 UTC
Bug Find in the newest official 4.2.9 Beta 


(In reply to grzegorzpedrycz from comment #0)
> Created attachment 126699 [details]
> Color selector  menu issue
> 
> SUMMARY
> 
> When you use color selector pop up menu ("Show color selector " ) and you 
> drag colorpicker point  to the edge of color box , menu is turning off. You
> cant take a colors from the edge of box . I mean you can but it frustrating
> and hard. One small mistake and menu is turning off.. . I show that
> situation in attached gif 
>  
> 
> 
> 
> SOFTWARE/OS VERSIONS
> Windows: 
> macOS: 
> Linux/KDE Plasma: 
> (available in About System)
> KDE Plasma Version: 
> KDE Frameworks Version: 
> Qt Version: 
> 
> ADDITIONAL INFORMATION
Comment 2 Ahab Greybeard 2020-03-09 16:59:02 UTC
I can conform this for 4.2.8, 4.2.9 beta and the latest Windows 4.3.0 prealpha portable .zip (git 36917c3).

The colour selector pop up can also be removed by pressing any key (Shift and Ctrl being 'safe' keys to use).

It does seem to be a UI shortfall and is particularly bad for the rectangular colour selector as reported.
Comment 3 Lynx3d 2020-03-10 01:13:06 UTC
I can confirm that 4.2.9-beta appimage and master has this issue, while 4.2.8 has not, so clearly a regression.

My testing points at this commit as the issue:
https://invent.kde.org/kde/krita/-/commit/8621ed93b311bd8035390bb8063609b7b312dd24

Obviously Qt::WindowFlags affect the generation of enter/leave events, but it's not documented anywhere (unless I'm blind), and searching the net a bit, people had plenty of "fun" already when newer Qt versions changed these hidden details.
Comment 4 grzegorzpedrycz 2020-03-10 08:41:56 UTC
The same here 4.2.8 is fine its clearly 4.2.9 issue
Comment 5 Halla Rempt 2020-03-10 09:02:06 UTC
Git commit cea9741dd7dbb37d4eaf812e7273d1c143c71217 by Boudewijn Rempt.
Committed on 10/03/2020 at 09:01.
Pushed by rempt into branch 'master'.

Use Qt::Popup only on MacOS, Qt::Tool on other systems

M  +4    -0    plugins/dockers/advancedcolorselector/kis_color_selector_base.cpp

https://invent.kde.org/kde/krita/commit/cea9741dd7dbb37d4eaf812e7273d1c143c71217
Comment 6 Halla Rempt 2020-03-10 09:02:17 UTC
Git commit d8e2e6d207b635df8d11afb2faf353a9192945af by Boudewijn Rempt.
Committed on 10/03/2020 at 09:02.
Pushed by rempt into branch 'krita/4.2'.

Use Qt::Popup only on MacOS, Qt::Tool on other systems

M  +4    -0    plugins/dockers/advancedcolorselector/kis_color_selector_base.cpp

https://invent.kde.org/kde/krita/commit/d8e2e6d207b635df8d11afb2faf353a9192945af
Comment 7 Ahab Greybeard 2020-03-10 09:27:25 UTC
This is strange because I've just downloaded and used a fresh 4.2.8 appimage and Windows portable .zip and they both show this, as do my old copies of the 4.2.6 and 4.2.7.1 appimage.
Anyway, if it's fixed then it's fixed.
Comment 8 grzegorzpedrycz 2020-03-10 09:32:02 UTC
Sure, Fix is part of current 4.2.9 beta right now  or i  should wait for new  update in upcoming days to get copy without that bug ?