Summary: | If the currently applied Colour Scheme is not found, Apply is never enabled when selecting other colour schemes | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | The Feren OS Dev <ferenosdev> |
Component: | kcm_colors | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | cyril.rossi, jpwhiting, kde, mwoehlke.floss, nate |
Priority: | NOR | ||
Version: | 5.17.2 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-desktop/443b028a1cb344604751963770105903b0a9e391 | Version Fixed In: | 5.18.5 |
Description
The Feren OS Dev
2020-03-08 02:04:47 UTC
Extra additional information: Double-clicking colour schemes to apply them still works. Git commit 4d33b8276e00471f6bfc14a174b3a33fe17627b3 by Cyril Rossi. Committed on 19/03/2020 at 09:47. Pushed by crossi into branch 'master'. KCM Colors fix apply button always disabled Summary: This is similar to D27384 Test Plan: In `kdeglobals` configuration file : * Edit `ColorScheme` in group `General` to a non existing value * Open the KCM, the default color scheme is selected with a warning message, * Select a different scheme, the apply button stay disabled forever. Reviewers: #plasma, ervin, bport, meven, broulik Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27944 M +5 -0 kcms/colors/colors.cpp https://commits.kde.org/plasma-desktop/4d33b8276e00471f6bfc14a174b3a33fe17627b3 Does this merge cleanly onto the stable branch? Might be nice to get it into 5.18.4 if possible for our LTS users. Sure, I can cherry-pick the commit and merge into 5.18 branch. Git commit 443b028a1cb344604751963770105903b0a9e391 by Cyril Rossi. Committed on 02/04/2020 at 13:18. Pushed by crossi into branch 'Plasma/5.18'. KCM Colors fix apply button always disabled Summary: This is similar to D27384 Test Plan: In `kdeglobals` configuration file : * Edit `ColorScheme` in group `General` to a non existing value * Open the KCM, the default color scheme is selected with a warning message, * Select a different scheme, the apply button stay disabled forever. Reviewers: #plasma, ervin, bport, meven, broulik Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27944 (cherry picked from commit 4d33b8276e00471f6bfc14a174b3a33fe17627b3) M +5 -0 kcms/colors/colors.cpp https://commits.kde.org/plasma-desktop/443b028a1cb344604751963770105903b0a9e391 |