Bug 418436

Summary:	'Share...' in context menu cannot be disabled
Product:	[Plasma] plasma-browser-integration	Reporter:	Frederick Zhang <frederick888>
Component:	Firefox	Assignee:	Kai Uwe Broulik <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, burster
Priority:	HI
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-browser-integration/7f3bc46f90440dd6baccb3e2b9b29212338d2b00	Version Fixed/Implemented In:
Sentry Crash Report:

Description Frederick Zhang 2020-03-03 14:51:58 UTC

SUMMARY
'Share...' in context menu cannot be disabled.

STEPS TO REPRODUCE
1. In add-on preferences, uncheck 'Content Sharing'
2. Open a webpage
3. Right click

OBSERVED RESULT
'Share...' stays in context menu.

EXPECTED RESULT
'Share...' is disabled.

SOFTWARE/OS VERSIONS
Firefox: 74.0b9 (64-bit) Arch Linux official package
Plasma Integration: 1.7

Comment 1 burster 2020-03-05 00:07:57 UTC

Confirmed.
If option is unchecked it disables functionality but 'Share...' entry remains.

FF 73.0.1 (64-Bit)
Plasma Integration 1.7
OS Arch Linux

Comment 2 Kai Uwe Broulik 2020-04-15 08:49:18 UTC

Git commit 7f3bc46f90440dd6baccb3e2b9b29212338d2b00 by Kai Uwe Broulik.
Committed on 15/04/2020 at 08:49.
Pushed by broulik into branch 'master'.

Show purpose context menu only when enabled

Check whether the extension is supported and enabled.
Unfortunately, I removed the loaded/unloaded singals for plugins in the host at some point and
so I don't have convenient signals for that anymore :(
I will add them back but for stable and older hosts that won't really help.

Differential Revision: https://phabricator.kde.org/D28707

M  +55   -7    extension/extension-purpose.js
M  +2    -0    extension/extension.js

https://commits.kde.org/plasma-browser-integration/7f3bc46f90440dd6baccb3e2b9b29212338d2b00

Comment 3 Patrick Silva 2020-05-16 18:42:58 UTC

This issue is happening again with Chromium and browsers based on it (tested Opera and Vivaldi)
running Plasma Browser Integration version 1.7.5. Firefox is not affected.

Operating System: Arch Linux 
KDE Plasma Version: 5.18.90
KDE Frameworks Version: 5.70.0
Qt Version: 5.15.0 rc2