Bug 418368

Summary: One of the view options of KNewStuff seems to be broken
Product: [Frameworks and Libraries] frameworks-knewstuff Reporter: Stefan Zurucker <s.zb>
Component: generalAssignee: Jeremy Whiting <jpwhiting>
Status: RESOLVED FIXED    
Severity: minor CC: admin, kdelibs-bugs, nate
Priority: NOR    
Version: 5.67.0   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In: 5.68
Attachments: Video demonstrating the bug

Description Stefan Zurucker 2020-03-01 19:05:50 UTC
Created attachment 126528 [details]
Video demonstrating the bug

SUMMARY
If the "images only" view is enabled, clicking an item doesn't do anything. 

STEPS TO REPRODUCE
1. Open System Settings > Go to one of the Appearance tabs.
2. Click "Download New [Appearance Item]"
3. Enable the "images only" preview option (the middle button for me; see video attachment)

OBSERVED RESULT
Clicking any item with this view option enabled results in all the list items becoming unclickable.

EXPECTED RESULT
As with the other two view options ("large" and "detailed"), clicking an item should open the preview page for the theme, wallpaper, color scheme, etc.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon 5.18 User Edition
KDE Plasma Version: 5.18.2
KDE Frameworks Version: 5.67
Qt Version: 5.14.1

ADDITIONAL INFORMATION
I have created a short video demonstrating the bug (see attachment to this post)
Comment 1 Stefan Zurucker 2020-03-01 19:09:48 UTC
Edit/Addendum: The Install button also doesn't work if this view option is enabled.
Comment 2 Dan Leinir Turthra Jensen 2020-03-02 09:38:21 UTC
Thanks for the report, working on a fix right now :) (luckily not the default view anywhere at the moment). The other issue you mention is unrelated, but already has a proposed fix elsewhere (so also thanks ;) ). The Phabricator diff is: https://phabricator.kde.org/D27777
Comment 3 Dan Leinir Turthra Jensen 2020-03-05 08:49:08 UTC
Git commit b9a1dd14800b45a06fe4e70f1f8079580a2967f1 by Dan Leinir Turthra Jensen.
Committed on 05/03/2020 at 08:49.
Pushed by leinir into branch 'master'.

Fix clicking thumb-only delegate

Summary:
This fixes a call to an attached property which only exists on the
delegate root, not the children.

Test Plan: Switch to the thumbnail only view and click an item. Notice that without the patch the click is ignored (and produces error output on the console), and that with the patch it works.

Reviewers: #frameworks, ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27777

M  +1    -1    src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml

https://commits.kde.org/knewstuff/b9a1dd14800b45a06fe4e70f1f8079580a2967f1