Summary: | Make kdsoap an optional dependency | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kio-extras | Reporter: | Nate Graham <nate> |
Component: | default | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED NOT A BUG | ||
Severity: | normal | CC: | faure, lbeltrame, sitter |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: | https://github.com/KDAB/KDSoap/issues/212 | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Nate Graham
2020-02-29 17:31:24 UTC
We've talked about it elsewhere and since we want distros to get kdsoap packaged sooner rather than later it's better if it is not optional. It sucks that this makes building master a lot less accessible for now, but in the end the only supported line-up for master moving forward is having smb with kdnssd and wsdiscovery support. So, the required-dependency does accurately represent the feature expectations here and the code is written that way also (i.e. making kdsoap optional would also require some ifdeffing on the code side). As a stop gap measure I'd suggest building without smb -DCMAKE_DISABLE_FIND_PACKAGE_Samba=ON if building kdsoap is not an option. Kdsoap only depends on Qt and has a cmake build system, it really isn't that hard to build if need be though. Currently there are licensing issues in kdsoap (EULA shipped in the source package which is incompatible with the other licenses there). Unless these are fixed, packaging kdsoap properly is a non-starter. The readme does say the eula only applies to commercial licensing. It's still included in the distributed tarball, which shouldn't happen. I have filed an issue upstream already. Well, let's get it changed in kdsoap then :) In the debian world when there is stuff that the policy has objections to the tarball is usually repacked without the objectionable content, effectively reducing the code to the DFSG-compliant, free license, bits. Perhaps something similar could be done as a stop-gap here. As I say, the readme makes it very clear what the terms of licensing are. |