Bug 418223

Summary:	Copying and pasting folder in place can result in system freeze and corrupted source folder
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Alexander Ewering <ae>
Component:	Overwrite dialog	Assignee:	David Faure <faure>
Status:	REPORTED ---
Severity:	critical	CC:	kdelibs-bugs, kfm-devel, nate
Priority:	NOR
Version:	5.67.0
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Alexander Ewering 2020-02-26 14:27:39 UTC

This is the first time that happened after a million successful similar operations, but it is so critical that I will still report it.

I often make a backup of a certain project folder before working on it.

That is, I open dolphin, left-click on the folder to select it, then hit Ctrl-C Ctrl-V in quick succession to create a copy of it.

This has worked fine at least 1000 times and resulted in the dialog asking to rename the pasted folder, and then a correct copy operation.

Yesterday however (I can't remember the exact steps because I was in a business meeting and had people chatting to me etc.), it resulted in:

- The whole desktop freezing upon hitting Ctrl-V
- IMPORTANTLY: The SOURCE (!) folder suddenly being almost COMPLETELY EMPTY. All regular files were gone, the only thing that was still there was the first level of sub-folders (all sub-subfolders were gone too, and obviously all files in them). It is almost as if dolphin had "forgotten" to ask for a new folder name and had recursively tried to copy the folder into itself!

It will probably be impossible to reproduce for you, but I swear it has happened and it is so critical that I simply had to report it despite not having good information for reproduction.

I don't think it's a hardware failure (though it was on an external USB SSD). I checked all logs, among them /var/log/syslog, and there are no unusual error messages for the time period where it happened (I can pinpoint the time period because I switched to a different tty when the desktop froze and I see getty starting up).

Comment 1 Nate Graham 2020-02-26 19:01:18 UTC

Yikes, that sounds pretty terrible. :( I'm sorry to hear it.

Comment 2 Alexander Ewering 2020-02-27 20:17:17 UTC

IMPORTANT UPDATE: Lo and behold, this is crazy. I just found a hidden folder '.Trash-1001' (1001 apparently being my UID) in the root folder of the SSD, and it contains the entire contents of the source folder that was destroyed during the copy operation! 

I guess that is an important piece of info for bug hunting!

Comment 3 2wxsy58236r3 2020-03-03 03:38:01 UTC

Is the S.M.A.R.T. report (and filesystem check, e.g. btrfs scrub) normal? How large (file number and size) is the folder you are trying to backup?

Comment 4 Alexander Ewering 2020-03-03 12:14:50 UTC

(In reply to 2wxsy58236r3 from comment #3)
> Is the S.M.A.R.T. report (and filesystem check, e.g. btrfs scrub) normal?
> How large (file number and size) is the folder you are trying to backup?

The folder is about 88 files, 16 sub-folders and 3.3 MB.

The smartctl output for the device is as follows:

----------------------------------------------------------------

root@cara:~# smartctl -d sat -a /dev/sda
smartctl 6.6 2016-05-31 r4324 [x86_64-linux-5.3.0-40-generic] (local build)
Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org

=== START OF INFORMATION SECTION ===
Device Model:     Samsung Portable SSD T5
Serial Number:    S49XNV0MB20053R
LU WWN Device Id: 5 002538 e00000000
Firmware Version: MVT42P1Q
User Capacity:    500,107,862,016 bytes [500 GB]
Sector Size:      512 bytes logical/physical
Rotation Rate:    Solid State Device
Form Factor:      mSATA
Device is:        Not in smartctl database [for details use: -P showall]
ATA Version is:   ACS-2, ATA8-ACS T13/1699-D revision 4c
SATA Version is:  SATA 3.1, 6.0 Gb/s (current: 6.0 Gb/s)
Local Time is:    Tue Mar  3 12:11:38 2020 GMT
SMART support is: Available - device has SMART capability.
SMART support is: Enabled

=== START OF READ SMART DATA SECTION ===
SMART overall-health self-assessment test result: PASSED

General SMART Values:
Offline data collection status:  (0x00) Offline data collection activity
                                        was never started.
                                        Auto Offline Data Collection: Disabled.
Self-test execution status:      (   0) The previous self-test routine completed
                                        without error or no self-test has ever 
                                        been run.
Total time to complete Offline 
data collection:                (    0) seconds.
Offline data collection
capabilities:                    (0x53) SMART execute Offline immediate.
                                        Auto Offline data collection on/off support.
                                        Suspend Offline collection upon new
                                        command.
                                        No Offline surface scan supported.
                                        Self-test supported.
                                        No Conveyance Self-test supported.
                                        Selective Self-test supported.
SMART capabilities:            (0x0003) Saves SMART data before entering
                                        power-saving mode.
                                        Supports SMART auto save timer.
Error logging capability:        (0x01) Error logging supported.
                                        General Purpose Logging supported.
Short self-test routine 
recommended polling time:        (   2) minutes.
Extended self-test routine
recommended polling time:        (  85) minutes.

SMART Attributes Data Structure revision number: 1
Vendor Specific SMART Attributes with Thresholds:
ID# ATTRIBUTE_NAME          FLAG     VALUE WORST THRESH TYPE      UPDATED  WHEN_FAILED RAW_VALUE
  5 Reallocated_Sector_Ct   0x0033   100   100   010    Pre-fail  Always       -       0
  9 Power_On_Hours          0x0032   099   099   000    Old_age   Always       -       120
 12 Power_Cycle_Count       0x0032   099   099   000    Old_age   Always       -       74
177 Wear_Leveling_Count     0x0013   100   100   000    Pre-fail  Always       -       0
179 Used_Rsvd_Blk_Cnt_Tot   0x0013   100   100   010    Pre-fail  Always       -       0
181 Program_Fail_Cnt_Total  0x0032   100   100   010    Old_age   Always       -       0
182 Erase_Fail_Count_Total  0x0032   100   100   010    Old_age   Always       -       0
183 Runtime_Bad_Block       0x0013   100   100   010    Pre-fail  Always       -       0
187 Reported_Uncorrect      0x0032   100   100   000    Old_age   Always       -       0
190 Airflow_Temperature_Cel 0x0032   079   039   000    Old_age   Always       -       21
195 Hardware_ECC_Recovered  0x001a   200   200   000    Old_age   Always       -       0
199 UDMA_CRC_Error_Count    0x003e   100   100   000    Old_age   Always       -       0
235 Unknown_Attribute       0x0012   099   099   000    Old_age   Always       -       72
241 Total_LBAs_Written      0x0032   099   099   000    Old_age   Always       -       253452502

SMART Error Log Version: 1
No Errors Logged

SMART Self-test log structure revision number 1
No self-tests have been logged.  [To run self-tests, use: smartctl -t]

SMART Selective self-test log data structure revision number 1
 SPAN  MIN_LBA  MAX_LBA  CURRENT_TEST_STATUS
    1        0        0  Not_testing
    2        0        0  Not_testing
    3        0        0  Not_testing
    4        0        0  Not_testing
    5        0        0  Not_testing
Selective self-test flags (0x0):
  After scanning selected spans, do NOT read-scan remainder of disk.
If Selective self-test is pending on power-up, resume after 0 minute delay.

-------------------------------------------------------------------------

e2fsck output for partition:

root@cara:~# umount /db
root@cara:~# e2fsck -f /dev/sda1
e2fsck 1.44.1 (24-Mar-2018)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information
/dev/sda1: 82336/30531584 files (1.0% non-contiguous), 47664514/122096008 blocks

------------------------------------------------------------------------

Comment 5 Alexander Ewering 2020-03-03 12:17:56 UTC

One thing that might or might not be relevant: I had to manually enable TRIM for this device as it's not officially supported due to the USB/SATA bridge used. TRIM is done periodically via systemd. However, no TRIM was taking place when the error occured and as mentioned earlier, no syslog error whatsoever were logged when the problem occured. So I guess it's really not a hardware-related problem.

Comment 6 David Faure 2020-08-02 09:33:50 UTC

'.Trash-1001' is the implementation of the Unix trash spec.

Could it be that you hit Del by mistake and KIO proceeded to move the source folder to the trash? Sorry for asking, but there's just no way that an actual directory copy would end up moving files to the trash...

Comment 7 Alexander Ewering 2020-08-03 14:36:48 UTC

(In reply to David Faure from comment #6)
> '.Trash-1001' is the implementation of the Unix trash spec.
> 
> Could it be that you hit Del by mistake and KIO proceeded to move the source
> folder to the trash? Sorry for asking, but there's just no way that an
> actual directory copy would end up moving files to the trash...

It's possible, though I have "DEL" assigned to "Delete" instead of "Move to trash".

Anyway, it hasn't ever happened again since then and before this issue causes any more unease and there's no obvious way how it could've been triggered, maybe it's best to close it.