Bug 418164

Summary:	Allow hiding the mute button while keeping the contextual menu option
Product:	[Plasma] plasmashell	Reporter:	kde
Component:	Task Manager and Icons-Only Task Manager widgets	Assignee:	Nate Graham <nate>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.18.1
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-desktop/3b2e4ddaa01ad067924f4efe0380bac1445232fa	Version Fixed/Implemented In:	5.18.3
Sentry Crash Report:

Description kde 2020-02-25 10:49:23 UTC

SUMMARY
In the icons-only task manager, on my setup the mute button is currently very small and hard to see, I end up clicking it by mistake fairly often. Muting programs isn't something I do very frequently, so using the "Mute" right-click menu is fine, however when the setting to display audio status icons is disabled, the contextual menu option to mute disappears as well. Request is to keep this menu option around when the icon is disabled instead of removing both.

STEPS TO REPRODUCE
1. Add icons-only task manager
2. Disable setting that displays application sound status


SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1

Comment 1 Nate Graham 2020-02-26 18:53:41 UTC

Yeah, that's definitely a bug.

Comment 2 Nate Graham 2020-02-26 19:55:55 UTC

I've submitted a patch to fix this: https://phabricator.kde.org/D27684

Comment 3 Nate Graham 2020-02-27 21:38:19 UTC

Git commit 3b2e4ddaa01ad067924f4efe0380bac1445232fa by Nate Graham.
Committed on 27/02/2020 at 21:37.
Pushed by ngraham into branch 'Plasma/5.18'.

[applets/taskmanager] Show PA-related features even when audio indicators are disabled

Summary:
There is a checkbox in the Task Manager settings with the text "Mark applications that
play audio". Unchecking it does much more than no longer marking applications that play
audio though; it disabled all PulseAudio-related features. This not only makes the label
inaccurate, but it also seems undesirable; a user could quite reasonably wish to disable
the audio indicators while still using PulseAudio-related functionality through the Task
Manager (e.g. muting an app from the context menu).

This patch makes the setting in question really and truly only show and hide the audio
indicator icon on the Task; other PA-related functionality is always loaded when
available.

Test Plan:
Open an app or window that can play audio and start playing audio with it
Make sure that audio indicators are visible
Right-click on the task and see that there's {nav Mute} item (provided by PA
Configure the Task Manager and disable audio indicators
See that the audio indicator icon is gone from the task
Right-click on the task and see that the {nav Mute} item is still there
Configure the Task Manager again and re-enable audio indicators
See that the audio indicator icon re-appears on the task
FIXED-IN: 5.18.3

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27684

M  +7    -4    applets/taskmanager/package/contents/ui/Task.qml
M  +3    -1    applets/taskmanager/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/3b2e4ddaa01ad067924f4efe0380bac1445232fa