| Summary: | Details of app are shown with broken layout in some cases | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Patrick Silva <bugseforuns> |
| Component: | discover | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol, nate |
| Priority: | NOR | Keywords: | regression, usability |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/discover/9b0652d5c724cb806bce5cb9cbb8e7d74a75222c | Version Fixed/Implemented In: | 5.19.0 |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
That's not a broken layout, it's the narrow/mobile vilew for a Form Layout. Fallout from https://cgit.kde.org/discover.git/commit/?id=40742348cf052310bb74fceaec33f906ee0e4f26 I guess we could avoid displaying the full URL string or something. Git commit 9b0652d5c724cb806bce5cb9cbb8e7d74a75222c by Nate Graham.
Committed on 06/03/2020 at 18:28.
Pushed by ngraham into branch 'master'.
Improve layout and appearance of app details view
Summary:
After porting to FormLayout in D27183, the layout can now be so wide due to the URLs
that it switches to the compact/mobile view. This patch re-arranges things a bit and
uses human-readable strings for the links instead of showing raw URLs. For safety,
this requires D27663 to be implemented first.
FIXED-IN: 5.19.0
Depends on D27663
Test Plan:
Before: normal-sized window (shows the compact/mobile view): {F8131970}
Before wide window: {F8131971}
After: normal-sized or wide window: {F8131972}
Reviewers: #vdg, #discover_software_store, apol, ndavis
Reviewed By: #vdg, #discover_software_store, apol, ndavis
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27664
M +10 -8 discover/qml/ApplicationPage.qml
https://commits.kde.org/discover/9b0652d5c724cb806bce5cb9cbb8e7d74a75222c
|
Created attachment 126283 [details] screenshot STEPS TO REPRODUCE 1. open discover and search for any of the following apps: eternal lands, girens for plex, gscan2pdf, luminance hdr (only flatpak version is affected), plasma engine explorer, plasmoid viewer, stepmania, warmux (only flatpak version is affected) 2. click on the app that you searched for to open its description page 3. OBSERVED RESULT layout of the details of the app on bottom of the description page is broken. Attached screenshot shows plasmoid viewer case. EXPECTED RESULT correct layout SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.18.80 KDE Frameworks Version: 5.68.0 Qt Version: 5.14.1