Bug 417981

Summary: Generic icon in "Configure" window
Product: [Applications] kinfocenter Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: Nate Graham <nate>
Status: RESOLVED FIXED    
Severity: normal CC: nate, notmart, plasma-bugs-null
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 5.18.2
Sentry Crash Report:
Attachments: "Configure" window of kinfocenter
"Configure" window of System Settings

Description Patrick Silva 2020-02-21 10:17:26 UTC
Created attachment 126248 [details]
"Configure" window of kinfocenter

STEPS TO REPRODUCE
1. open kinfocenter
2. click on hamburger button beside search field > Configure 
3. 

OBSERVED RESULT
generic icon represents "General" section.

EXPECTED RESULT
"Configure" window of system settings shows system settings icon,
then "Configure" window of kinfocenter could show kinfocenter icon.
Compare the attached screenshots please.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1
Comment 1 Patrick Silva 2020-02-21 10:18:01 UTC
Created attachment 126249 [details]
"Configure" window of System Settings
Comment 2 Nate Graham 2020-02-22 03:28:00 UTC
Confirmed, but maybe we don't even need to show this menu item/window at all. There's nothing to configure when it's in Info Center mode.
Comment 3 Nate Graham 2020-02-22 05:55:28 UTC
Patch: https://phabricator.kde.org/D27565
Comment 4 Nate Graham 2020-03-13 19:44:22 UTC
Git commit 3d515026d59c663fef2db26663acad40292eb5fc by Nate Graham.
Committed on 13/03/2020 at 19:44.
Pushed by ngraham into branch 'master'.

Hide configure action in Info center mode

Summary:
There's nothing to configure, so hide the action that shows the configuration window.
Related: bug 417977
FIXED-IN: 5.19.0

Test Plan:
Open Info Center
Click on hamburger menu
No more {nav Configure...} menu item

Reviewers: #plasma, mart, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27565

M  +4    -0    app/SettingsBase.cpp

https://commits.kde.org/systemsettings/3d515026d59c663fef2db26663acad40292eb5fc
Comment 5 Nate Graham 2020-09-23 20:36:04 UTC
Git commit 8060235a74b8d1f9f2b3558066d69ac3569b1caf by Nate Graham.
Committed on 23/09/2020 at 20:35.
Pushed by ngraham into branch 'Plasma/5.18'.

Hide configure action in Info center mode

Summary:
There's nothing to configure, so hide the action that shows the configuration window.
Related: bug 417977
FIXED-IN: 5.18.2

Test Plan:
Open Info Center
Click on hamburger menu
No more {nav Configure...} menu item

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27565

M  +5    -0    app/SettingsBase.cpp
M  +38   -11   sidebar/SidebarMode.cpp

https://invent.kde.org/plasma/systemsettings/commit/8060235a74b8d1f9f2b3558066d69ac3569b1caf