Bug 417972

Summary: Breeze icons are inconsistent when using Evolution
Product: [Plasma] Breeze Reporter: elman
Component: IconsAssignee: Nate Graham <nate>
Status: RESOLVED FIXED    
Severity: normal CC: bugseforuns, kainz.a, nate, noahadvs
Priority: NOR    
Version: 5.18.1   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=417969
Latest Commit: Version Fixed In: 5.68
Sentry Crash Report:
Attachments: Icons in Evolution
evolution - appointment

Description elman 2020-02-21 08:27:00 UTC
Created attachment 126241 [details]
Icons in Evolution

SUMMARY
Before Plasma 5.18 I used different sets of icons for Qt apps (Breeze) and for GTK apps (Adwaita). Now that settings are synchronized, I have to use Breeze icons also for GTK apps. This brings issues with consistency of the icons. I do not know where the problem lies, but when I use Evolution, some icons have different style than others. Is this because some icons are missing in Breeze set?

STEPS TO REPRODUCE
1. Open Evolution on Plasma 5.18 with Breeze icon set

OBSERVED RESULT
Icons have different styles.

EXPECTED RESULT
All icons have same style.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Manjaro
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1

ADDITIONAL INFORMATION
See screenshot
Comment 1 Nate Graham 2020-02-21 15:48:03 UTC
In this case, it looks like the issue is that the toolbar buttons are using a 24px or larger icon size, and there's no monochrome icon for user-trash, only colorful.

It looks like we'll need for every icon that has both monochrome and colorful versions depending on the size to have a 24px size to ensure the right style gets used in GNOME apps.

Showing the Nautilus icon in the toolbar is probably an Evolution issue, not a Breeze icons issue. We don't have an icon that looks like that in Breeze.
Comment 2 Nate Graham 2020-02-21 16:03:16 UTC
I'm going to fix the issue for this icon, but we have a long-term plan to fix it universally for everything at build-time (to eliminate manual errors). See https://phabricator.kde.org/T11950
Comment 3 Nate Graham 2020-02-21 16:06:04 UTC
Oh hmm. There is no 24px size for places icons, and user-trash is a places icon.

Should we create a 24px folder to hold 24px versions of all these icons for compatibility's sake?
Comment 4 Noah Davis 2020-02-21 16:16:03 UTC
(In reply to Nate Graham from comment #3)
> Oh hmm. There is no 24px size for places icons, and user-trash is a places
> icon.
> 
> Should we create a 24px folder to hold 24px versions of all these icons for
> compatibility's sake?

There's no harm as long as we eventually automate the creation of 24px icons.
Comment 5 Nate Graham 2020-02-21 17:40:27 UTC
Ah screw it, I'll just do that automation right now. It's about time.
Comment 6 Nate Graham 2020-02-21 22:00:26 UTC
Patch: https://phabricator.kde.org/D27557
Comment 7 elman 2020-02-25 13:53:45 UTC
Created attachment 126406 [details]
evolution - appointment

Appointment creation is event better example of wrong icons.
Comment 8 Nate Graham 2020-02-25 14:42:24 UTC
Fixed by that patch, BTW. Can you try again once KDE Frameworks 5.68 is released?
Comment 9 elman 2020-02-25 15:08:51 UTC
Of course I will try. No problem. :)
Comment 10 elman 2020-03-25 09:20:25 UTC
I just checked icons in KDE Frameworks 5.68 and although icons still have different styles (monochrome vs colourful), sizes are correct which is great. Thanks a lot!