Summary: | Cannot drag and drop links into plasma-notes widget | ||
---|---|---|---|
Product: | [Plasma] kdeplasma-addons | Reporter: | luca <luca.pedrielli> |
Component: | notes | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate, plasma-bugs |
Priority: | NOR | Keywords: | regression |
Version: | 5.18.1 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kdeplasma-addons/b03539a0d8d3b9e5a7c580c926c618bde0dbe374 | Version Fixed In: | 5.18.3 |
Description
luca
2020-02-20 21:15:54 UTC
Can confirm with Firefox and Chromium. I'm absolutely not an expert in qml, but in this (perfectible) way it seems to work: ------------------------------------------------------------------------------ *** main.qml 2020-02-21 10:17:26.376005566 +0100 --- main.qml.modified 2020-02-21 19:07:32.898012627 +0100 *************** *** 146,151 **** --- 146,152 ---- } QQC2.ScrollView { + id: scrollview anchors { top: parent.top left: parent.left *************** *** 308,317 **** DragDrop.DropArea { id: dropArea ! anchors.fill: mainTextArea function positionOfDrop(event) { ! return mainTextArea.positionAt(event.x, event.y + mainTextArea.flickableItem.contentY) } onDrop: { --- 309,318 ---- DragDrop.DropArea { id: dropArea ! anchors.fill: scrollview function positionOfDrop(event) { ! return mainTextArea.positionAt(event.x, event.y) } onDrop: { ------------------------------------------------------------------------------ in this way I've restored cursor shape changes: ---------------------------------------------------------------------------- *************** *** 337,342 **** --- 338,349 ---- mainTextArea.deselect() } onDragEnter: mainTextArea.forceActiveFocus() + + MouseArea { + anchors.fill: parent + cursorShape: mainTextArea.hoveredLink ? Qt.PointingHandCursor : Qt.IBeamCursor + acceptedButtons: Qt.NoButton + } } RowLayout { --------------------------------------------------------------------------- Nice. Would you be interested in submitting a patch? That's the best way to get devs to review your code. Instructions are located at https://community.kde.org/Infrastructure/Phabricator I can help if you need a hand with anything. thanks for the trust, but i think i did enough. I have reported the bug and indicated where to act. Best, Luca. I sent a pull request on github Best, Luca. What's the URL? We use GitHub as a mirror, btu development activity happens on https://phabricator.kde.org/ instead. I can help walk you through the process if you need a hand. I had an old account on github ;) https://github.com/KDE/kdeplasma-addons/pull/6 I'll take a look at https://phabricator.kde.org/ Best. Git commit b03539a0d8d3b9e5a7c580c926c618bde0dbe374 by Nate Graham, on behalf of Luca Pedrielli. Committed on 26/02/2020 at 18:16. Pushed by ngraham into branch 'Plasma/5.18'. [applets/notes] Fix drag&drop links and cursor shape regression Summary: Restore the possibility to drag and drop the links from browser, and the cursor shape now changes on links. FIXED-IN: 5.18.3 Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: ngraham Tags: #plasma Differential Revision: https://phabricator.kde.org/D27673 M +9 -2 applets/notes/package/contents/ui/main.qml https://commits.kde.org/kdeplasma-addons/b03539a0d8d3b9e5a7c580c926c618bde0dbe374 |