Bug 417921

Summary:	Tab showing search results has "unknown" icon
Product:	[Applications] dolphin	Reporter:	Patrick Silva <bugseforuns>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	kfm-devel, meven29, nate
Priority:	NOR
Version:	19.12.2
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/kio/eb20176d1a42eebd4c6c3cbdb5dca6a854760736	Version Fixed In:	5.68
Sentry Crash Report:
Attachments:	screenshot

Description Patrick Silva 2020-02-20 11:28:10 UTC

Created attachment 126196 [details]
screenshot

STEPS TO REPRODUCE
1. open Dolphin
2. press ctrl+t to open another tab
3. press ctrl+f and search for anything

OBSERVED RESULT
tab showing the search results has "unknown" icon.
See the attached screenshot please.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1

ADDITIONAL INFORMATION
related to bug 417069

Comment 1 Patrick Silva 2020-02-20 11:29:37 UTC

EXPECTED RESULT
tab showing search results should have a suitable icon

Comment 2 Nate Graham 2020-02-21 14:08:21 UTC

*** Bug 386182 has been marked as a duplicate of this bug. ***

Comment 3 Méven Car 2020-02-22 11:35:53 UTC

Git commit eb20176d1a42eebd4c6c3cbdb5dca6a854760736 by Méven Car.
Committed on 22/02/2020 at 11:35.
Pushed by meven into branch 'master'.

KIO::iconNameForUrl: fix searching for kde protocol icons

Summary:
iconName was set to mt.iconName() at the beginning, but this returns always "application-octet-stream" making all subsequent iconName.isEmpty() check not work as expected.
This patch sets iconName to mt.iconName() only when needed.
Related: bug 417922, bug 417069
FIXED-IN: 5.68

Test Plan:
In dolphin:
 - open "Recent Files"
 - Ctrl+T

 - open any folder
 - Ctrl+T
 - Ctrl+F (Search
 - Search for anything, type something then return

Same for smb:/ location

In all cases the protocol icon is now visible.

Reviewers: ngraham, #frameworks, dfaure, broulik, sitter

Reviewed By: ngraham, dfaure, sitter

Subscribers: sitter, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27539

M  +13   -1    autotests/kfileitemtest.cpp
M  +14   -18   src/core/global.cpp

https://commits.kde.org/kio/eb20176d1a42eebd4c6c3cbdb5dca6a854760736