Bug 417888

Summary:	[Wayland] activating minimized window from another virtual desktop adds window to current virtual desktop
Product:	[Plasma] plasmashell	Reporter:	Alexandre Pereira <pereira.alex>
Component:	Task Manager and Icons-Only Task Manager widgets	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, herzenschein, johannespfrang+kde, nate, plasma-bugs-null
Priority:	NOR	Keywords:	wayland-only
Version First Reported In:	5.18.1
Target Milestone:	1.0
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=410084
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Alexandre Pereira 2020-02-19 17:31:56 UTC

SUMMARY
Tested using wayland:
If i have taskmanager set to show windows from all virtual desktops, and I have for example a window on virtual desktop 1 ( VD1 ) and I am on VD2 and click on that same window entry, the following happens:

* if the window is minimized, it will copy the window to current VD2 ( the window is now on VD1 and VD2.
* if the window is not minimized, the desktop will switch to VD1 and activate the window ( window is only on VD1, which i think its the correct ).

hope it is clear, thanks !

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Alexandre Pereira 2020-03-03 13:34:50 UTC

been testing a fix, which seems to work ( tested on wayland )

on file /usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/code/tools.js:

function activateTask(index, model, modifiers, task) {
    if (modifiers & Qt.ShiftModifier) {
        tasksModel.requestNewInstance(index);
    } else if (model.IsGroupParent === true) {
        if ((iconsOnly || modifiers == Qt.ControlModifier) && backend.canPresentWindows()) {
            task.toolTipAreaItem.hideToolTip();
            tasks.presentWindows(model.WinIdList);
        } else if (groupDialog.visible) {
            groupDialog.visible = false;
        } else {
            groupDialog.visualParent = task;
            groupDialog.visible = true;
        }
    } else {
        if (model.IsMinimized === true) {
            //tasksModel.requestToggleMinimized(index);
            tasksModel.requestActivate(index);
        } else if (model.IsActive === true) {
            tasksModel.requestToggleMinimized(index);
        } else {
            tasksModel.requestActivate(index);
        }
    }
}


---

commenting "//tasksModel.requestToggleMinimized(index);" seems to do the trick, in unminimizing the window and showing it on the proper desktop !

Comment 2 Alexandre Pereira 2020-03-03 14:11:45 UTC

tested the fix on X11 also, works properly without issues

Comment 3 Thiago Sueto 2020-08-29 14:01:04 UTC

I believe I experienced this issue, but I didn't manage to find how to reproduce.
It usually happens when I'm working, and my setup typically includes 4 virtual desktops (2 axes), with WPS Office, Slack, Kontact and Firefox open in each one, opening Telegram and Elisa on occasion too, wherein WPS Office and Kontact are the usual culprits in this, I think Slack too (all on XWayland).

I'll test this workaround next week and report if the issue is no longer reproducible.

Did you find a way to consistently reproduce it? And by

> If i have taskmanager set to show windows from all virtual desktops

Do you mean you set the option "Show only tasks from current Activity"? That's what I use.

Comment 4 Alexandre Pereira 2020-08-29 14:32:41 UTC

> Do you mean you set the option "Show only tasks from current Activity"? That's what I use.

It can be on the same activity or different.

The option I mean is disabling 'Show only tasks: "From current desktop"'

So that you minimize a window on one VD, and click on it on the taskmanager while on another VD

Comment 5 Thiago Sueto 2020-09-01 16:57:24 UTC

Now I get it, managed to reproduce it consistently.

I also used this fix the whole day and it works fine so far.

Comment 6 Patrick Silva 2020-10-16 22:33:24 UTC

bug 410084 seems related

Comment 7 Nate Graham 2021-03-04 20:58:26 UTC

Does someone want to submit that fix as a merge request? Pretty please? :)

Comment 8 Nate Graham 2022-01-12 18:24:05 UTC

Ping regarding submitting that patch. :)

Comment 9 Alexandre Pereira 2022-01-13 00:10:56 UTC

Retested this bug and it seems it is already fixed!

So closing as fixed!

Comment 10 Nate Graham 2022-01-13 01:47:02 UTC

Hooray!