Bug 417849

Summary:	Edit mode toolbar flickers when closed
Product:	[Plasma] plasmashell	Reporter:	Patrick Silva <bugseforuns>
Component:	Edit Mode	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, qydwhotmail
Priority:	NOR
Version First Reported In:	5.18.1
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-desktop/commit/1e547fe7ef946ebdfd503a9506f9ffae94555a1f	Version Fixed In:	5.26.1 5.24.7
Sentry Crash Report:
Attachments:	screen recording

Description Patrick Silva 2020-02-18 22:58:55 UTC

STEPS TO REPRODUCE
1. start Wayland session
2. right click on wallpaper > Customize layout
3. close the edit mode toolbar on top by clicking on its "x" button

OBSERVED RESULT
edit mode toolbar flickers when closed

EXPECTED RESULT
edit mode toolbar should close smoothly

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1

Comment 1 Patrick Silva 2020-02-20 13:35:48 UTC

Humm, this behavior also occurs on X11.

Comment 2 Patrick Silva 2020-02-20 13:40:59 UTC

Created attachment 126209 [details]
screen recording

Comment 3 Nate Graham 2020-02-21 06:01:37 UTC

Can reproduce on X11.

Comment 4 Bug Janitor Service 2022-09-21 12:08:56 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1165

Comment 5 Fushan Wen 2022-09-21 12:57:34 UTC

Git commit 5f384e75bef57231fe01155da479375c315a9706 by Fushan Wen.
Committed on 21/09/2022 at 12:57.
Pushed by fusionfuture into branch 'master'.

desktoptoolbox: fix flickering on closing

The visible property needs to keep true until opacity becomes 0,
otherwise the toolbox will flicker on closing.
FIXED-IN: 5.26 5.24.7

M  +1    -1    toolboxes/desktoptoolbox/contents/ui/ToolBoxContent.qml

https://invent.kde.org/plasma/plasma-desktop/commit/5f384e75bef57231fe01155da479375c315a9706

Comment 6 Fushan Wen 2022-09-21 12:58:01 UTC

Git commit 51a36f960f48dd5c18fb73b53924dafcc7414e07 by Fushan Wen.
Committed on 21/09/2022 at 12:57.
Pushed by fusionfuture into branch 'Plasma/5.24'.

desktoptoolbox: fix flickering on closing

The visible property needs to keep true until opacity becomes 0,
otherwise the toolbox will flicker on closing.
FIXED-IN: 5.26 5.24.7


(cherry picked from commit 5f384e75bef57231fe01155da479375c315a9706)

M  +1    -1    toolboxes/desktoptoolbox/contents/ui/ToolBoxContent.qml

https://invent.kde.org/plasma/plasma-desktop/commit/51a36f960f48dd5c18fb73b53924dafcc7414e07

Comment 7 Patrick Silva 2022-10-11 15:42:12 UTC

It's reproducible again.

Operating System: Arch Linux
KDE Plasma Version: 5.26.0
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6
Graphics Platform: Wayland

Comment 8 Fushan Wen 2022-10-12 01:34:15 UTC

Git commit 1e547fe7ef946ebdfd503a9506f9ffae94555a1f by Fushan Wen.
Committed on 12/10/2022 at 01:34.
Pushed by fusionfuture into branch 'Plasma/5.26'.

desktoptoolbox: fix flickering on closing

The visible property needs to keep true until opacity becomes 0,
otherwise the toolbox will flicker on closing.
FIXED-IN: 5.26 5.24.7


(cherry picked from commit 5f384e75bef57231fe01155da479375c315a9706)

M  +1    -1    toolboxes/desktoptoolbox/contents/ui/ToolBoxContent.qml

https://invent.kde.org/plasma/plasma-desktop/commit/1e547fe7ef946ebdfd503a9506f9ffae94555a1f

Comment 9 Fushan Wen 2022-10-12 01:34:55 UTC

Forgot to cherry-pick to 5.26 branch, should be fixed in 5.26.1