| Summary: | Size of standalone User Feedback kcm is too small if slider is set to rightmost position | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
| Component: | kcm_feedback | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | cfeck, kde, nate, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 5.18.1 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/be4a0ae13a52a361cb413a35fe9b08d326240f9f | Version Fixed/Implemented In: | 5.18.2 |
| Sentry Crash Report: | |||
| Attachments: |
screen recording
screen recording on Plasma 5.18.1 |
||
Git commit 285155fad1f30c35476c074d470cde6f253d3e9b by Nate Graham.
Committed on 17/02/2020 at 00:34.
Pushed by ngraham into branch 'Plasma/5.18'.
[kcms/feedback] Improve default kcmshell window size
Summary:
FIXED-IN: 5.18.1
Test Plan:
Better default size when showing the most info: {F8107763}
However window is too now big when showing the least amount of info: {F8107762}
...But that seems kind of unavoidable unless we want to dynamically resize the window,
which people seem to hate.
Reviewers: #plasma, #vdg, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27448
M +2 -1 kcms/feedback/package/contents/ui/main.qml
https://commits.kde.org/plasma-workspace/285155fad1f30c35476c074d470cde6f253d3e9b
Created attachment 126160 [details]
screen recording on Plasma 5.18.1
Not completely fixed on Plasma 5.18.1.
Operating System: Arch Linux
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Works for me. What's your screen size? (In reply to Nate Graham from comment #4) > Works for me. What's your screen size? 23 inches 1080p? (In reply to Nate Graham from comment #6) > 1080p? yes Same for me. I have so much crap in there it would hardly fit on screen at any size :) Argh you guys are killing me lol! I could go up to `implicitHeight: Kirigami.Units.gridUnit * 34` (up from 33), but then the default height would be taller then 600px which would make the bottom button row cut off on some old crappy netbook screens. But maybe we could ignore those? Or maybe we could just give up on kcmshell and fix this whole dang class of bug once and for all by just opening System Settings itself (Bug 402790). Nate, you are free to make the window larger than 600 pix on initial open. What we usually reject is creating user interfaces that have a minimumSize that demands a larger size. We have scrollbars to handle small screens, and if the window needs more room, it will automatically use these. Btw, the same issue is with users that have a 1366x786 screen, but need to use a large font size due to eyesight. You won't be able to cramp much lines in such a screen, but scrollbars to the rescue! :) Git commit be4a0ae13a52a361cb413a35fe9b08d326240f9f by Nate Graham. Committed on 19/02/2020 at 21:38. Pushed by ngraham into branch 'Plasma/5.18'. [kcms/feedback] Increase default window height a bit more FIXED-IN: 5.18.2 M +1 -1 kcms/feedback/package/contents/ui/main.qml https://commits.kde.org/plasma-workspace/be4a0ae13a52a361cb413a35fe9b08d326240f9f |
Created attachment 126077 [details] screen recording STEPS TO REPRODUCE 1. open system settings > user feedback 2. drag the slider to rightmost position and click on "Apply" button 3. close system settings 4. open User Feedback kcm via apps launcher or krunner OBSERVED RESULT As we can see in the attached screen recording, the User Feedback window is too small by default. Information on bottom is always hidden on opening. EXPECTED RESULT window size should be adjusted to make all information visible on opening. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.18.0 KDE Frameworks Version: 5.67.0 Qt Version: 5.14.1