Bug 417739

Summary:	Multirow + "tag block" display for image tags?
Product:	[Applications] digikam	Reporter:	Jens <jens-bugs.kde.org>
Component:	Albums-TableView	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version First Reported In:	7.0.0
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	7.5.0
Sentry Crash Report:

Description Jens 2020-02-16 10:05:21 UTC

SUMMARY
I would like to see a slightly optimized view for tags in Digikams main thumbnail view. Specifically, 

- multirow display (more room for tags) so tags are not cut off
  (maybe with max. three rows, or a configurable number) 

and

- inverted colors for the tag text
  (so you can see whether a "," belongs to the tag or separates two tags)

I think this makes a lot of sense and this kind of tag display is also in use in many other apps, even in input fields, see e.g. Stack Overflow or Apple apps.

What do you think?

Comment 1 caulier.gilles 2020-02-16 10:09:03 UTC

I don't understand this report. Are you talking about tags tree-view ?

Can you make a mockup please ?

Gilles Caulier

Comment 2 Maik Qualmann 2020-02-16 10:22:58 UTC

I believe that we already have bug reports for the display of the tags in the thumbnails. In the right sidebar you can see which tags are included in the image. Space is limited in the thumbnail. I also don't like changing colors, also with regard to the user using different color themes.

Maik

Comment 3 caulier.gilles 2020-02-16 18:07:28 UTC

Why not to use the TableView mode with the customized raw showing tags list (and others properties) ?

Gilles Caulier

Comment 4 caulier.gilles 2020-02-16 18:10:28 UTC

Maik,

I just take a look and in TableView mode, DK properties do not include Tags... snif...

Gilles

Comment 5 Jens 2020-02-16 20:13:43 UTC

IMHO:
Table view is a huge waste of screen space, especially for widescreen displays.
(See also the geolocation editor, but that's another bug.) 

The main reason is that thumbnails have a certain minimum height, but most of the text has a really tiny height. In addition, in the current 7.0-beta3 the thumbnail has a really large top and bottom border / padding.

Comment 6 caulier.gilles 2020-02-17 18:20:52 UTC

Git commit 01a21d34b89df292671c68b9147579542edb62b0 by Gilles Caulier.
Committed on 17/02/2020 at 18:15.
Pushed by cgilles into branch 'master'.

TableView: add support to Tag-Paths as configurable row in list-view.

M  +1    -0    NEWS
M  +0    -1    core/app/views/tableview/TODO.TABLEVIEW
M  +24   -4    core/app/views/tableview/tableview_column_digikam.cpp
M  +2    -1    core/app/views/tableview/tableview_column_digikam.h
M  +5    -0    core/app/views/tableview/tableview_columnfactory.cpp

https://invent.kde.org/kde/digikam/commit/01a21d34b89df292671c68b9147579542edb62b0

Comment 7 caulier.gilles 2020-02-17 18:22:55 UTC

Jens,

In all cases, please try my last commit to see if it can help in your workflow.

I will run this evening the Windows bundles updates, and tomorrow morning the Linux AppImage...

Gilles Caulier

Comment 8 caulier.gilles 2020-02-18 09:45:25 UTC

Git commit 891464beb98a487d5c07f83320be8f6945857ed8 by Gilles Caulier.
Committed on 18/02/2020 at 09:43.
Pushed by cgilles into branch 'master'.

TableView: show multiple tags assigned to one item using multi-lines

M  +92   -5    core/app/views/tableview/tableview_column_digikam.cpp
M  +2    -0    core/app/views/tableview/tableview_columnfactory.cpp
M  +21   -14   core/app/views/tableview/tableview_columnfactory.h

https://invent.kde.org/kde/digikam/commit/891464beb98a487d5c07f83320be8f6945857ed8

Comment 9 caulier.gilles 2020-02-18 09:50:26 UTC

Jens,

Definitively, a multi-row model to show tags will be only managed by the TableView, not the IconView. For this last one free space is really limited.
This is why TableView mode exists.

So, we cannot easily apply a new model based on rows over IconView

Gilles Caulier

Comment 10 caulier.gilles 2022-01-09 18:40:58 UTC

Fixed with my 2 last commit.