Bug 417737

Summary:	File operations locked under Windows
Product:	[Applications] digikam	Reporter:	Jan van Bekkum <Jan.vanBekkum>
Component:	Albums-Engine	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, madal254, metzpinguin
Priority:	NOR
Version First Reported In:	7.0.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/kde/digikam/commit/d85733a8f64d1ba4f5067a9c190b094b2b353781	Version Fixed/Implemented In:	7.0.0
Sentry Crash Report:

Description Jan van Bekkum 2020-02-16 09:51:01 UTC

SUMMARY
Used V 7.0.0 beta 3

Album stays in list after deletion

STEPS TO REPRODUCE
1. Create album name album1
2. Select delete album1
3. Select delete album1 again

OBSERVED RESULT
The folder has been deleted (no longer visible with file manager) but stays in the list of albums. The second time a message appears that the album cannot be deleted. It still remains in thew list.

EXPECTED RESULT
Album no longer visible in album list.

SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 caulier.gilles 2020-02-16 09:57:56 UTC

Not reproducible here with 7.0.0-beta3 under Linux Mageia 6 and 7 (Plasma desktop).

Gilles Caulier

Comment 2 caulier.gilles 2020-02-16 09:59:46 UTC

What do you seen in the console while this operation ? Follow instructions here :

https://www.digikam.org/contribute/

Gilles Caulier

Comment 3 Maik Qualmann 2020-02-16 10:13:22 UTC

We know the problem if the collection is part of a Windows network share. We cannot change this, it would require native Windows code.

Maik

Comment 4 Maik Qualmann 2020-02-16 10:14:40 UTC

Possible that the folder is locked by another open program. Restart Windows and try again.

Maik

Comment 5 Maik Qualmann 2020-02-16 10:16:02 UTC

*** Bug 417738 has been marked as a duplicate of this bug. ***

Comment 6 Maik Qualmann 2020-04-03 19:36:37 UTC

Git commit d85733a8f64d1ba4f5067a9c190b094b2b353781 by Maik Qualmann.
Committed on 03/04/2020 at 19:34.
Pushed by mqualmann into branch 'master'.

try to fix locked file operations under Windows
do not add QFileSystemWatcher to images in the cache
Related: bug 402938

M  +5    -0    core/libs/threadimageio/fileio/loadingcache.cpp

https://invent.kde.org/kde/digikam/commit/d85733a8f64d1ba4f5067a9c190b094b2b353781

Comment 7 Maik Qualmann 2020-04-22 05:33:10 UTC

*** Bug 420403 has been marked as a duplicate of this bug. ***

Comment 8 Maik Qualmann 2020-04-23 04:31:56 UTC

Git commit 977fee83cf0da275c708908f3ebef5a7cd848f5f by Maik Qualmann.
Committed on 23/04/2020 at 04:30.
Pushed by mqualmann into branch 'master'.

replace QFileSystemWatcher in the LoadingCache interface

M  +2    -2    core/libs/database/utils/scan/scancontroller_p.h
M  +0    -5    core/libs/fileactionmanager/fileworkeriface.cpp
M  +43   -116  core/libs/threadimageio/fileio/loadingcache.cpp
M  +8    -47   core/libs/threadimageio/fileio/loadingcache.h
M  +0    -8    core/libs/threadimageio/fileio/loadingcacheinterface.cpp
M  +0    -5    core/libs/threadimageio/fileio/loadingcacheinterface.h

https://invent.kde.org/kde/digikam/commit/977fee83cf0da275c708908f3ebef5a7cd848f5f