Summary: | kdevelop-pg-qt fails to build on s390x in Ubuntu 20.04 Focal | ||
---|---|---|---|
Product: | [Applications] kdevelop | Reporter: | Rik Mills <rikmills> |
Component: | general | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | aaronpuchert, kfunk, kossebau |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kdevelop-pg-qt/0f830b2abc7763f6598f7f1a84f5af403d402a02 | Version Fixed In: |
Description
Rik Mills
2020-02-14 23:40:20 UTC
Looks valid to me. The template is only declared in kdev-pg/kdev-pg-code-gen.h, while the definition is in kdev-pg/kdev-pg-code-gen.cpp. When the template is referenced from kdev-pg/kdev-pg-ast-gen.cpp, the definition isn't available, so the compiler can't instantiate the template. The solution would be to move the template to the header file or instantiate all necessary variants explicitly [1]. By the way, Clang can warn about situations like that with -Wundefined-func-template. [1] https://en.cppreference.com/w/cpp/language/function_template#Explicit_instantiation Still failing. If there is no fix by time of Ubuntu beta freeze, I may have to ask as precaution ask for 2.2.1 to be removed. :( Git commit 0f830b2abc7763f6598f7f1a84f5af403d402a02 by Milian Wolff. Committed on 02/03/2020 at 21:58. Pushed by mwolff into branch '2.2'. Fix linking on s390x Ensure all symbols are available and don't hide the template instantiation. M +23 -24 kdev-pg/kdev-pg-code-gen.cpp M +13 -1 kdev-pg/kdev-pg-code-gen.h https://commits.kde.org/kdevelop-pg-qt/0f830b2abc7763f6598f7f1a84f5af403d402a02 I've pushed a fix to the 2.2 branch and master, can you try that please? if it fixes the issue, then we can create a 2.2.2 release (In reply to Milian Wolff from comment #4) > I've pushed a fix to the 2.2 branch and master, can you try that please? if > it fixes the issue, then we can create a 2.2.2 release Yes, that fixes the build. :) Thank you! |