Bug 417535

Summary:	Pressing Alt-F4 breaks show/hide
Product:	[Applications] yakuake	Reporter:	Nicolás Alvarez <nalvarez>
Component:	general	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andrewfhou, aspotashev, bugseforuns, nate
Priority:	NOR	Keywords:	triaged
Version First Reported In:	3.0.5
Target Milestone:	---
Platform:	Debian stable
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Nicolás Alvarez 2020-02-13 03:24:30 UTC

If I press Alt-F4 on the Yakuake window, Yakuake stays running, but the toggle key doesn't work anymore. There's no way to make yakuake show/hide anymore.

STEPS TO REPRODUCE
1. Yakuake configured like this: show on all desktops, keep open when losing focus, use open/retract to focus window. I don't know if all these settings matter, but I include them for consistency in the reproducing steps.
2. Open yakuake window and focus it.
3. Press Alt-F4. The Yakuake window instantly disappears, with no animation.
4. Press F12 (or whatever you have as toggle shortcut). Yakuake reveals again, with all sessions still there, so it didn't quit.
5. Press F12 again. Yakuake doesn't hide. If open but unfocused, F12 is supposed to focus it again (given settings in step 1), but that doesn't happen either. F12 doesn't do anything anymore in any state.

I have investigated this, and it looks like after Alt-F4, the X window ID changes (maybe a new window is created?). This can be confirmed with xwininfo after step 2 and after step 4. KWindowSystem::activeWindow() will return the real new ID of the window, but MainWindow::winId() still returns the old ID, as if Qt didn't notice the ID changed. Since activeWindow() == winId() is now never true, Yakuake thinks it's never focused so it doesn't hide. It also gives the wrong ID to activateWindow so it doesn't focus.

(I managed to fix a running instance and save myself from restarting my zillion tabs by setting mainWindow->data->winid in QWidget's private fields to the correct ID with gdb)

I'm not sure what the *correct* behavior of Alt-F4 would be though. Warn user about multiple tabs and then quit app, like Konsole? Hide window as if with F12, letting the user open it again? Ignore it altogether?


SOFTWARE/OS VERSIONS
OS: Debian Buster
KDE Plasma Version: 5.11.5
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3
xcb platform

Comment 1 Patrick Silva 2020-02-28 19:08:52 UTC

cannot reproduce. F12 does not reveal yakuake after I press alt+F4 in in the step 3.

yakuake 19.12.2
Operating System: Arch Linux 
KDE Plasma Version: 5.18.2
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1

Comment 2 Nate Graham 2020-02-29 17:50:17 UTC

Hmm, I also cannot confirm when using those settings. Alt+F4 closes the window as expected.

Comment 3 Andrew Hou 2020-02-29 18:55:46 UTC

Also cannot reproduce. Looking at System Monitor, the yakuake process is killed upon hitting Alt+F4.

yakuake 19.12.2-0
OS Version: KDE Neon 5.18 User Edition
KDE Plasma Version: 5.18.2
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1

Comment 4 Nicolás Alvarez 2021-09-26 00:06:05 UTC

In Debian Bullseye (yakuake 20.12.1, frameworks 5.78, Qt 5.15.2) I can't reproduce anymore either. Pressing Alt-F4 now shows a warning that I have multiple open tabs and they will be closed if I quit. If click "Quit" on that dialog (or if I only have 1 tab so the warning doesn't show), Yakuake quits normally.

I'll mark this as fixed, though I'm now curious which of the updated components fixed it...