| Summary: | Show the brush preset buttons in the toolbar as inactive when the current tool doesn't support editing brush presets. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | cadaverous.doll |
| Component: | Usability | Assignee: | Scott Petrovic <scottpetrovic> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | griffinvalley, halla, tamtamy.tymona |
| Priority: | NOR | ||
| Version First Reported In: | 4.2.8 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/f5c9f3276ac3f5faee1faaad56da55782fde7164 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Comparison of active and inactive brush editor icon in 4.2.9 appimage on Cinnamon
Screenshot of the toolbar icons in 4.2.9 and in 5.0-alpha (6fc84c8) |
||
|
Description
cadaverous.doll
2020-02-10 01:01:19 UTC
This is deliberate, I'm afraid, based on previous bug reports that said it was confusing to edit brush settings when the tool in question doesn't use them... Created attachment 127841 [details]
Comparison of active and inactive brush editor icon in 4.2.9 appimage on Cinnamon
The reporter is asking for the indication that the brush editor cannot be used at the moment, which I agree is not clear enough. When comparing two images closely, I can see that the background of the inactive one is a shade darker than the background of the active/enabled one (and I can see that it's consistent with other buttons etc.), the problem is that this background is nearly entirely covered by the brush tip icon, so it's only maybe one pixel edge around it. The brush selection icons is more visibly different. Still:
- a beginner might not know that disabled brush selection equals disabled brush editor, too
- it's still not nearly as visible as the Opacity slider, for example
Since my native style is not from the list of allowed ones, I believe my used style is fusion.
I would vote to reopen this bug report.
I guess we can change the button then. And actually, if you press F5, the brush editor will open, even if there's no image open. Created attachment 135424 [details]
Screenshot of the toolbar icons in 4.2.9 and in 5.0-alpha (6fc84c8)
In Krita 5.0 the buttons were made flat, which made even the slight difference that was there before disappear.
Assigning Scott since he made the icons flat. I think we need to figure out a solution before any work could potentially be done. By assigning it to me I am guessing your goal is we are going to have a discussion in the ticket about what to do. This is a brush preset editor that isn't limited to a currently selected brush. You can change brushes and edit any brush from this window. Are we wanting to disable the editor completely depending on what is the active tool? I think just making it not flat again is not a good solution. There needs to be something. Is this really a problem that needs to be solved? A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1606 Git commit f5c9f3276ac3f5faee1faaad56da55782fde7164 by Dmitry Kazakov, on behalf of Tom Tom Tom. Committed on 03/10/2022 at 08:10. Pushed by dkazakov into branch 'master'. Allow usage of various paintop widgets without active painting tool M +1 -31 libs/ui/kis_paintop_box.cc https://invent.kde.org/graphics/krita/commit/f5c9f3276ac3f5faee1faaad56da55782fde7164 |