Bug 417347

Summary: Big empty space between toolbar and content view in new GHNS dialog.
Product: [Frameworks and Libraries] frameworks-kdeclarative Reporter: Philipp Stefan <neptunecat34>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: normal CC: admin, filipfila.kde, kdelibs-bugs-null, nate
Priority: NOR    
Version First Reported In: 5.67.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/kdeclarative/d9b52d900471f8ed7187062dbfd53fbb313a7bb9 Version Fixed/Implemented In: 5.68
Sentry Crash Report:
Attachments: Screenshot of new GHNS dialog

Description Philipp Stefan 2020-02-09 17:03:27 UTC 
Created attachment 125788 [details]
Screenshot of new GHNS dialog

There is an odly big amount of space between the toolbar of the new GHNS dialog and it's actual content view area.

See attached screenshot; taken from the latest[1] 'This week in KDE' blog post

[1] https://pointieststick.com/2020/02/08/this-week-in-kde-plasma-5-18-in-two-days/
Comment 1 Filip Fila 2020-02-09 23:04:58 UTC 
IMO the toolbar separator is also unnecessary. And then if the scroll view got pulled up a bit it would look better.
Comment 2 Dan Leinir Turthra Jensen 2020-02-10 08:51:57 UTC 
This is not defined by KNewStuff. The layout work for that specific bit is done by the GridViewKCM component (which is why it is so similar to any of the new KCMs). Redirecting to the appropriate component - and thanks for the report :)
Comment 3 Nate Graham 2020-02-11 14:40:47 UTC 
Will be fixed by https://phabricator.kde.org/D27315
Comment 4 David Redondo 2020-02-13 20:48:49 UTC 
Git commit d9b52d900471f8ed7187062dbfd53fbb313a7bb9 by David Redondo.
Committed on 13/02/2020 at 20:48.
Pushed by davidre into branch 'master'.

Fix size of the header in GridViewKCM

Summary:
The same as in SimpleKCM and ScrollviewKCM
FIXED-IN: 5.68

Test Plan: {F8097147}

Reviewers: mart, broulik, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27315

M  +3    -1    src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

https://commits.kde.org/kdeclarative/d9b52d900471f8ed7187062dbfd53fbb313a7bb9