Bug 417268

Summary: cover art is not entirely visible in "Now playing" view
Product: [Applications] Elisa Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR    
Version: 19.12.2   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 20.04.0
Attachments: screenshot

Description Patrick Silva 2020-02-07 13:33:05 UTC
STEPS TO REPRODUCE
1. play any track
2. select "Now playing" in the left side
3. 

OBSERVED RESULT
as we can see in attached screenshot, cover art is not entirely visible below the seek bar

EXPECTED RESULT
cover art should be entirely visible in "Now playing" view

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.1
Comment 1 Patrick Silva 2020-02-07 13:33:37 UTC
Created attachment 125737 [details]
screenshot
Comment 2 Nate Graham 2020-02-07 14:17:05 UTC
This is intentional, but I admit it's not my favorite thing either.

As you can see, the album art is entirely visible in the headerbar on top (albeit in smaller form) so I kine of wonder what we even need this skinny strip in the Now Playing view for anyway.

Nice taste in music, BTW. :)
Comment 3 Matthieu Gallien 2020-02-07 20:40:58 UTC
(In reply to Nate Graham from comment #2)
> This is intentional, but I admit it's not my favorite thing either.
> 
> As you can see, the album art is entirely visible in the headerbar on top
> (albeit in smaller form) so I kine of wonder what we even need this skinny
> strip in the Now Playing view for anyway.
> 
> Nice taste in music, BTW. :)

When I implemented this view, I worked on the basis of a design where it looked nice on itself. Integrated in the whole UI, it is somewhat odd. I agree.

We could maybe have it in full size but behind the text with the appropriate visual effect such that the text is still easy to read ?
Comment 4 Nate Graham 2020-02-08 04:19:21 UTC
I think that's a great idea. I've submitted a merge request: https://invent.kde.org/kde/elisa/merge_requests/79
Comment 5 Nate Graham 2020-02-12 17:01:55 UTC
Git commit 003f0ba3c09b5e6b2035649c9f2edb2847f44b18 by Nate Graham.
Committed on 12/02/2020 at 17:01.
Pushed by ngraham into branch 'master'.

Change style in Context view to use blurred album art as the background
FIXED-IN: 20.04.0

M  +104  -96   src/qml/ContextView.qml

https://invent.kde.org/kde/elisa/commit/003f0ba3c09b5e6b2035649c9f2edb2847f44b18