Bug 417266

Summary: Make memcheck/tests/linux/sigqueue usable with musl
Product: [Developer tools] valgrind Reporter: Stefan Maksimovic <stefan.maksimovic>
Component: generalAssignee: Julian Seward <jseward>
Status: RESOLVED FIXED    
Severity: normal CC: mark, mips32r2
Priority: NOR    
Version First Reported In: 3.15 SVN   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: proposed solution

Description Stefan Maksimovic 2020-02-07 12:54:59 UTC
Created attachment 125733 [details]
proposed solution

Remove offsetof(siginfo_t, _sifields) from the test.
"_sifields" isn't mandatory field of struct siginfo_t so
it shouldn't be used in regular user program.

There is no functional impact on test.
Comment 1 Stefan Maksimovic 2020-03-02 13:41:50 UTC
Did anyone have a chance to take a look at this in the meantime?
Comment 2 Petar Jovanovic 2020-04-17 18:43:33 UTC
Everyone OK to submit this?
Comment 3 Mark Wielaard 2020-04-23 14:49:41 UTC
I think this is fine to go in.
This is only in some debug code, so shouldn't impact the test.

But musl is a little pedantic, they actually do support that field, they just call it differently from the glibc and linux uapi header for some reason they added an extra underscore...