Summary: | Amarok fails to load lyrics from lyrics.wikia.com | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Pedro de Carvalho Gomes <pedrogomes81> |
Component: | Context View/Lyrics | Assignee: | Pedro de Carvalho Gomes <pedrogomes81> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 2.9.0 | ||
Target Milestone: | kf5 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/amarok/7f966e2a46c92eeec2991feec30fb061c41c0b67 | Version Fixed In: |
Description
Pedro de Carvalho Gomes
2020-02-07 10:39:09 UTC
Please join the amarok-devel@kde.org mailing list for this, and submit your fix to phabricator.kde.org, subscribing the group "amarok". FWIW: we do no work on the Qt4 branch anymore since quite some time, master is using Qt5 and KDE frameworks5 now. Thank you Myriam for the reply. I have created a review request (D27369) for this bug, and others Git commit 7f966e2a46c92eeec2991feec30fb061c41c0b67 by Heiko Becker, on behalf of Pedro Gomes. Committed on 25/02/2020 at 21:41. Pushed by heikobecker into branch 'master'. Fix loading of lyrics from lyrics.wikia.com Summary: Fix error where Amarok failed to load lyrics from lyrics.wikia.com because the domain was being redirected to lyrics.fandom.com. The fix does two things: - update the base API Url to the redirected domain lyrics.fandom.com, thus skipping the redirection - makes LyricsManager react to possible future redirections Reviewers: #amarok, amarok-devel, heikobecker Reviewed By: #amarok, heikobecker Subscribers: #amarok, pgomes, amarok-devel Differential Revision: https://phabricator.kde.org/D27369 M +18 -1 src/lyrics/LyricsManager.cpp M +3 -0 src/lyrics/LyricsManager.h https://commits.kde.org/amarok/7f966e2a46c92eeec2991feec30fb061c41c0b67 |