Bug 417221

Summary: "Tags Filter" not honouring "AND" modifier
Product: [Applications] digikam Reporter: raymond.d.lucas
Component: Albums-FiltersAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: raymond.d.lucas
Priority: NOR    
Version First Reported In: 7.0.0   
Target Milestone: ---   
Platform: Mint (Debian based)   
OS: Linux   
Latest Commit: https://invent.kde.org/kde/digikam/commit/810ebc60ee4b9d20ef9b085f50424d0dad6871c6 Version Fixed/Implemented In: 7.0.0
Sentry Crash Report:

Description raymond.d.lucas 2020-02-06 09:42:40 UTC 
SUMMARY

I've tried several of the 7.0.0 AppImage builds (currently beta2) and they all seem to have two problems when using the Tags Filter option:
1. Selecting the "AND" modifier does not seem to have any effect. (this is the one I care about)
2. It allows you to select both "OR" and "AND" at the same time. (I don't really care about this, but it doesn't seem quite right).

In 6.4 and earlier the AND modifier behaved as expected e.g. if you select cats AND dogs, you only get pictures with both, as opposed to cats AND dogs which would show all pictures with either a cat or dog or both.

Also, you could select either "OR" or "AND" (not both).

STEPS TO REPRODUCE
1. Go to an Album with tagged images OR from Browse > Tags select one Tag which results in numerous images. (There may be other first steps that lead to the same result)
2. Go to the Filter tab on the right hand edge.
3. Under Tags Filter, select one tag.  Not the number of matches.
4. Select a second tag which does not completely overlap with the first.  The number of matches should increase (default behaviour is to "OR" these).
5. Change to "AND".

OBSERVED RESULT
The number of matches is unchanged.

EXPECTED RESULT
The number of matches decreases.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Mint 19.3, Linux (x86_64) release 4.15.0-76-generic
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 raymond.d.lucas 2020-02-06 09:49:06 UTC 
Even though I re-read it a number of times, I still made a typo at the **.  The following should read:

In 6.4 and earlier the AND modifier behaved as expected e.g. if you select cats AND dogs, you only get pictures with both, as opposed to cats **OR** dogs which would show all pictures with either a cat or dog or both.
Comment 2 Maik Qualmann 2020-02-06 17:06:13 UTC 
Git commit 810ebc60ee4b9d20ef9b085f50424d0dad6871c6 by Maik Qualmann.
Committed on 06/02/2020 at 17:05.
Pushed by mqualmann into branch 'master'.

fix tags filter AND/OR modifier
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +8    -4    core/app/filters/filtersidebarwidget.cpp

https://invent.kde.org/kde/digikam/commit/810ebc60ee4b9d20ef9b085f50424d0dad6871c6