Bug 416888

Summary: Cities of North and South Korea needs to be separated
Product: [Applications] kstars Reporter: Shinjo Park <kde>
Component: generalAssignee: Jasem Mutlaq <mutlaqja>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: git   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/kstars/0b818253b1a52cc37ce7fe34ddc423ee426d445d Version Fixed/Implemented In: 3.4.2
Sentry Crash Report:
Attachments: Modified citydb.sqlite, now listing North and South Korea separately.

Description Shinjo Park 2020-01-28 22:33:20 UTC 
SUMMARY
The citydb.sqlite from current git lists both North and South Korean cities under the same country "Korea". This is practically incorrect, so we need to separate both Koreas for this moment.

STEPS TO REPRODUCE
1. git checkout https://cgit.kde.org/kstars.git/
2. Open kstars/data/citydb.sqlite
3. Check where country == 'Korea'

OBSERVED RESULT
Both North and South Korean cities are mixed.

EXPECTED RESULT
These cities should go to North Korea:
id=540, 'Ch''ongjin'
id=1334, 'Hungnam'
id=1507, 'Kimch''aek'
id=1428, 'Kaesong'
id=1766, 'Maando'
id=2305, 'P''yongyang'
id=2804, 'Sinuiju'
id=3336, 'Wonsan'
id=3383, 'Yupojin'

All the rest should go to South Korea.

Also there are some errors in South Korean cities too:
id=719, 'Daegwallyeong' -> 'Province' should be 'Gangwon'
id=797, 'Dokdo' -> 'Province' should be 'Gyeongbuk'
id=1089, 'Name' should be 'Geumsan'
Comment 1 Jasem Mutlaq 2020-03-25 15:10:04 UTC 
Can you please submit a patch?
Comment 2 Shinjo Park 2020-03-25 17:31:57 UTC 
Created attachment 127013 [details]
Modified citydb.sqlite, now listing North and South Korea separately.

Data source for latitude/longitude is Wikidata, as of today.
Comment 3 Jasem Mutlaq 2020-03-25 18:30:22 UTC 
Git commit 0b818253b1a52cc37ce7fe34ddc423ee426d445d by Jasem Mutlaq.
Committed on 25/03/2020 at 18:18.
Pushed by mutlaqja into branch 'master'.

Fix North and South Korea cities. Patch submitted by Shinjo Park
FIXED-IN:3.4.2

M  +-    --    kstars/data/citydb.sqlite

https://commits.kde.org/kstars/0b818253b1a52cc37ce7fe34ddc423ee426d445d