Bug 416756

Summary: when searching for duplicates, only one photo is shown if the other one is in a group (and not the first of the group)
Product: [Applications] digikam Reporter: Daniel <daniel-other+kdebug>
Component: Searches-SimilarityAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal CC: metzpinguin
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 7.0.0
Sentry Crash Report:

Description Daniel 2020-01-25 16:27:11 UTC 
SUMMARY
When searching for duplicates in a collection with grouped images with duplicate images from images from this group, only the first image of the group is shown as a reference image on the right, for all other images, only the duplicate is shown


STEPS TO REPRODUCE
1. have a collection with grouped photos
2. have multiple duplicate photos of one of those grouped.
3. search for duplicates
4. for the first image in the group, both, the reference and duplicate, are shown; for all others of the group, only the duplicate photo is shown.

OBSERVED RESULT
Only the first photo of grouped photos shows up as a reference photo when searching for duplicates.

EXPECTED RESULT
all others should show up at their respective duplicate, because it is weird to search for duplicates and have only one image show up.

SOFTWARE/OS VERSIONS
current git branch

ADDITIONAL INFORMATION
Comment 1 Daniel 2020-01-25 16:33:47 UTC 
Also, when searching using the fuzzy search for grouped images, they are not found.

Everything works as expected if "show grouped fotos" is enabled for the group.
Comment 2 Maik Qualmann 2020-01-25 17:08:28 UTC 
For this reason, the "Show All Grouped Items As Open" option has recently been added to the View menu.

Maik
Comment 3 Daniel 2020-01-25 17:12:56 UTC 
(In reply to Maik Qualmann from comment #2)
> For this reason, the "Show All Grouped Items As Open" option has recently
> been added to the View menu.
> 
> Maik
I saw that too, but I think a notice would be handy in the "duplicates" tab.

When you search using the fuzzy search you expect it to find all fotos (or at least I do)
Comment 4 Maik Qualmann 2020-01-25 17:29:56 UTC 
Then we would have to write the note anywhere when filtering images, searching for images, etc. This is why this option is available. A user can also argue that the images have been grouped so that they are no longer visible and that they are now shown in the duplicate search.

Maik
Comment 5 Daniel 2020-01-25 17:41:04 UTC 
(In reply to Maik Qualmann from comment #4)
> Then we would have to write the note anywhere when filtering images,
> searching for images, etc. This is why this option is available. A user can
> also argue that the images have been grouped so that they are no longer
> visible and that they are now shown in the duplicate search.
> 
> Maik

Indeed, that's a good point.

Maybe the bottom status bar would be a good place for the note: A exclamation mark icon when the setting "show all grouped images as open" is disabled, with an alt hover text like "this result might be incomplete because images which are in a group aren't shown."

Daniel