Bug 416680

Summary:	Shortcut keys do not have :collapse: and :expand:
Product:	[Applications] kdenlive	Reporter:	ferweer <gyrlgith>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	fritzibaby
Priority:	NOR
Version First Reported In:	19.12.1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/kdenlive/commit/05670931d5a58116d6180fac327039822df2719a	Version Fixed/Implemented In:
Sentry Crash Report:

Description ferweer 2020-01-24 07:13:25 UTC

SUMMARY
It's good to have smaller effects and tracks to increase editing comfort.
But I wish I could assign a shortcut key to it.

OBSERVED RESULT
At the moment you can only :collapse: and :expand: effect lists and tracks with a click

EXPECTED RESULT
Collapse effect property
Expand effect property
Collapse truck
Expand truck
It is better to have these shortcut key settings.

Operating System: Kubuntu 19.04
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.12.2

Comment 1 Jean-Baptiste Mardelle 2020-01-24 12:12:28 UTC

Git commit ddc4751f760195e6d1f36a0271f87b40c088b203 by Jean-Baptiste Mardelle.
Committed on 24/01/2020 at 12:12.
Pushed by mardelle into branch 'master'.

Add shortcut to collapse/expand current effect or track
Default shortcut set as '<'

M  +7    -0    src/assets/assetpanel.cpp
M  +2    -0    src/assets/assetpanel.hpp
M  +7    -0    src/effects/effectstack/view/collapsibleeffectview.cpp
M  +2    -0    src/effects/effectstack/view/collapsibleeffectview.hpp
M  +10   -0    src/effects/effectstack/view/effectstackview.cpp
M  +4    -0    src/effects/effectstack/view/effectstackview.hpp
M  +26   -0    src/mainwindow.cpp
M  +2    -0    src/mainwindow.h
M  +1    -1    src/timeline2/view/qml/TrackHead.qml
M  +2    -2    src/timeline2/view/qml/timeline.qml
M  +9    -0    src/timeline2/view/timelinecontroller.cpp
M  +2    -0    src/timeline2/view/timelinecontroller.h

https://invent.kde.org/kde/kdenlive/commit/ddc4751f760195e6d1f36a0271f87b40c088b203

Comment 2 emohr 2020-01-25 09:00:03 UTC

Thank you for the idea.

With this commit it works properly: https://invent.kde.org/kde/kdenlive/commit/05670931d5a58116d6180fac327039822df2719a

You can test with Kdenlive_Nightly_Appimage
https://binary-factory.kde.org/job/Kdenlive_Nightly_Appimage_Build/lastSuccessfulBuild/artifact/ 

Will be comming with next update.

Comment 3 ferweer 2020-01-25 17:29:27 UTC

you have to use a mouse to check each one.(In reply to Jean-Baptiste Mardelle from comment #1)
OK, I checked both collupse / expand in the track and effect list.
You're doing great things! Thank you!

By the way, the annoyance is that the effects list doesn't work with a tablet stylus (this is reported in a separate bug for both kdenlive and xsetwacom), so

Comment 4 ferweer 2020-01-25 17:31:52 UTC

The check was done with kdenlive-20.03.70-0567093-x86_64.appimage.
The effect selected in the effect list and the track selected in the track could be collapsed and expanded using shortcut keys.