Bug 416627

Summary: Swap FG-BG-Colour icon missing in current master
Product: [Applications] krita Reporter: Rebecca Breu <rebecca>
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Debian stable   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Colour swap icon: difference in 4.2.8 and master

Description Rebecca Breu 2020-01-22 21:34:07 UTC
Created attachment 125311 [details]
Colour swap icon: difference in 4.2.8 and master

In the current master (my build from just now or the nightly appimage 21fb8e2), the little arrow icon next to the foreground/background icons in the toolbar is missing. You can still click the area to swap colours.

In the 4.2.8 appimage, the arrow icon is present.

See attached image.
Comment 1 Halla Rempt 2020-01-22 21:53:06 UTC
That's probably because master now allows the breeze style to be used; the icon itself has not changed.
Comment 2 Lynx3d 2020-01-22 22:18:38 UTC
Git commit 7572e2de933ab99a3508b0a6c8b944d4028a55ce by Mathias Wein.
Committed on 22/01/2020 at 22:16.
Pushed by mwein into branch 'master'.

Fix arrow color in KoDualColorButton

commit f867486c5e835cd09d7894b1e4d2c69ce10dbdad accidentally replaced
deprecated QPalette::foreground() with window() instead of windowText().

M  +1    -1    libs/ui/widgets/KoDualColorButton.cpp

https://invent.kde.org/kde/krita/commit/7572e2de933ab99a3508b0a6c8b944d4028a55ce
Comment 3 Halla Rempt 2020-01-28 09:50:29 UTC
Git commit 51cf882b800704e21f7c5dd934d38bfca344ccf9 by Boudewijn Rempt, on behalf of Mathias Wein.
Committed on 28/01/2020 at 09:17.
Pushed by rempt into branch 'krita/4.2'.

Fix arrow color in KoDualColorButton

commit f867486c5e835cd09d7894b1e4d2c69ce10dbdad accidentally replaced
deprecated QPalette::foreground() with window() instead of windowText().
(cherry picked from commit 7572e2de933ab99a3508b0a6c8b944d4028a55ce)

M  +1    -1    libs/ui/widgets/KoDualColorButton.cpp

https://invent.kde.org/kde/krita/commit/51cf882b800704e21f7c5dd934d38bfca344ccf9