Bug 416604

Summary:	plugins-dockers-animation-timeline_model_test (Failed)
Product:	[Applications] krita	Reporter:	Halla Rempt <halla>
Component:	Unittests	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	griffinvalley
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/2bf6c0ad468f8d9e2eb1dc0dff1ae2137751382f	Version Fixed/Implemented In:
Sentry Crash Report:

Description Halla Rempt 2020-01-22 15:03:49 UTC

246/285 Testing: plugins-dockers-animation-timeline_model_test
246/285 Test: plugins-dockers-animation-timeline_model_test
Command: "/home/boud/dev/b-krita/plugins/dockers/animation/tests/timeline_model_test"
Directory: /home/boud/dev/b-krita/plugins/dockers/animation/tests
"plugins-dockers-animation-timeline_model_test" start time: Jan 22 15:24 CET
Output:
----------------------------------------------------------
********* Start testing of TimelineModelTest *********
Config: Using QtTest library 5.13.2, Qt 5.13.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0)
PASS   : TimelineModelTest::initTestCase()
QWARN  : TimelineModelTest::testConverter() KoColor debug runtime checks are active.
FAIL!  : TimelineModelTest::testConverter() Compared values are not the same
   Actual   (converter.rowCount()): 6
   Expected (3)                   : 3
   Loc: [/home/boud/dev/krita/plugins/dockers/animation/tests/timeline_model_test.cpp(93)]
PASS   : TimelineModelTest::testModel()
PASS   : TimelineModelTest::testView()
PASS   : TimelineModelTest::testOnionSkins()
QDEBUG : TimelineModelTest::slotBang() Entering "TimelineModelTest::slotBang()" !!!!
PASS   : TimelineModelTest::slotBang()
PASS   : TimelineModelTest::cleanupTestCase()
Totals: 6 passed, 1 failed, 0 skipped, 0 blacklisted, 2239ms
********* Finished testing of TimelineModelTest *********
<end of output>
Test time =   2.31 sec
----------------------------------------------------------
Test Failed.
"plugins-dockers-animation-timeline_model_test" end time: Jan 22 15:24 CET
"plugins-dockers-animation-timeline_model_test" time elapsed: 00:00:02
----------------------------------------------------------

Comment 1 Dmitry Kazakov 2020-08-10 19:39:33 UTC

Git commit 21a1a20bce05b78fba5f18b6a8a645ef5c69102b by Dmitry Kazakov.
Committed on 10/08/2020 at 19:39.
Pushed by dkazakov into branch 'krita/4.3'.

Fix and unbreak TimelineModelTest

It got broken after we made all nodes visible in timeline by default

M  +1    -5    plugins/dockers/animation/tests/CMakeLists.txt
M  +8    -0    plugins/dockers/animation/tests/timeline_model_test.cpp
M  +3    -3    sdk/tests/empty_nodes_test.h

https://invent.kde.org/graphics/krita/commit/21a1a20bce05b78fba5f18b6a8a645ef5c69102b

Comment 2 Dmitry Kazakov 2020-08-12 17:53:13 UTC

Git commit 2bf6c0ad468f8d9e2eb1dc0dff1ae2137751382f by Dmitry Kazakov.
Committed on 12/08/2020 at 17:52.
Pushed by dkazakov into branch 'master'.

Fix and unbreak TimelineModelTest

It got broken after we made all nodes visible in timeline by default

# Conflicts:
#	plugins/dockers/animation/tests/timeline_model_test.cpp

M  +1    -5    plugins/dockers/animation/tests/CMakeLists.txt
M  +8    -0    plugins/dockers/animation/tests/timeline_model_test.cpp
M  +3    -3    sdk/tests/empty_nodes_test.h

https://invent.kde.org/graphics/krita/commit/2bf6c0ad468f8d9e2eb1dc0dff1ae2137751382f