Bug 416487

Summary:	multiple soft-links to directories - first one incorrect
Product:	[Applications] k3b	Reporter:	Graham Menhennitt <graham>
Component:	Data Project	Assignee:	k3b developers <k3b>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aacid, michalm, trueg
Priority:	NOR
Version:	19.12
Target Milestone:	---
Platform:	Other
OS:	FreeBSD
Latest Commit:	https://commits.kde.org/k3b/3cd2d2111fd7d897edbc6af202fba07bc819174a	Version Fixed In:
Sentry Crash Report:

Description Graham Menhennitt 2020-01-20 07:47:05 UTC

SUMMARY
Adding multiple soft-links to directories to data project doesn't add first one correctly.

STEPS TO REPRODUCE
1. Create new data project
2. Drag multiple soft links to directories into project
3. Answer "Always follow links"

OBSERVED RESULT
The first directory link is not added correctly (but all others are).


EXPECTED RESULT
All directory links should be followed.

SOFTWARE/OS VERSIONS
FreeBSD: 12-stable
KDE Plasma Version: 5-17.5
KDE Frameworks Version: 5.66.0
Qt Version: 5.13.2

ADDITIONAL INFORMATION
Deleting the bad directory from the project and then re-adding it and answering "Follow link now" causes it to be correctly added.

Comment 1 Albert Astals Cid 2020-01-21 21:25:09 UTC

Broken because someone did not read the code correctly, sigh #385677

Comment 2 Albert Astals Cid 2020-01-21 21:28:40 UTC

Git commit 3cd2d2111fd7d897edbc6af202fba07bc819174a by Albert Astals Cid.
Committed on 21/01/2020 at 21:26.
Pushed by aacid into branch 'release/19.12'.

Fix adding multiple symlinks to a data project

A bit sad that the break was added because someone reported that it gave
a warning and noone took the time to read the code and say "no but the
fallthrough here is intentional"
Related: bug 385677

M  +2    -1    src/projects/k3bdataurladdingdialog.cpp

https://commits.kde.org/k3b/3cd2d2111fd7d897edbc6af202fba07bc819174a