Summary: | Replace Vokoscreen with VokoscreenNG | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Olivier BELLEUX <o.g.m.belleux> |
Component: | general | Assignee: | Jeremy Whiting <jpwhiting> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, harogaston, kde, kdelibs-bugs, nate |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 5.66.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/knewstuff/5613fd66c5f42c8acdcb72586292e5fd9346e7b3 | Version Fixed In: | 5.70 |
Sentry Crash Report: |
Description
Olivier BELLEUX
2020-01-19 14:55:08 UTC
This is the commit that added vokoscreen in the first place: https://cgit.kde.org/knewstuff.git/commit/?id=bf82fe7c222fd635906f1c3e9380600559bfdc15 Changing some stuff there should be pretty easy. Would you like to have a go at it? I can help you. bug 417575 is related (In reply to Nate Graham from comment #1) > This is the commit that added vokoscreen in the first place: > https://cgit.kde.org/knewstuff.git/commit/ > ?id=bf82fe7c222fd635906f1c3e9380600559bfdc15 > > Changing some stuff there should be pretty easy. Would you like to have a go > at it? I can help you. Hi! I'll do it. I have one question though. The package is still called vokoscreen (at least in the AUR) for the vokoscreenNG version. Should I keep or update to the new name? Maybe my question does not make a lot of sense. But hey it will be my first patch ;) Cheers! I opened https://phabricator.kde.org/D28397 Thanks! You did great. Fantastic first patch. Git commit 5613fd66c5f42c8acdcb72586292e5fd9346e7b3 by Nate Graham, on behalf of Gastón Haro. Committed on 07/04/2020 at 18:30. Pushed by ngraham into branch 'master'. Replace Vokoscreen with VokoscreenNG Summary: The original Vokoscreen project has been abandoned and superseeded by VokoscreenNG. This patch updates the references. FIXED-IN: 5.70 Test Plan: Spectacle -> Tools -> Record Screen the new VokoscreenNG entry should appear and the new website referenced. (If other tools are installed it will appear under "More") Reviewers: #knewstuff, ngraham, leinir Reviewed By: ngraham Subscribers: apol, pino, IlyaBizyaev, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D28397 M +2 -2 data/kmoretools-desktopfiles/_update_all_files.sh R +3 -3 data/kmoretools-desktopfiles/vokoscreenNG.desktop [from: data/kmoretools-desktopfiles/vokoscreen.desktop - 098% similarity] R +- -- data/kmoretools-desktopfiles/vokoscreenNG.png [from: data/kmoretools-desktopfiles/vokoscreen.png - 100% similarity] M +2 -2 src/kmoretools/kmoretoolspresets.cpp https://commits.kde.org/knewstuff/5613fd66c5f42c8acdcb72586292e5fd9346e7b3 Good evening to all of you, Once again, thank you all, for your work, you make Kde the best graphical interface for Gnu / Linux (in all objectivity, of course !) Dear Nate, I can't wait to read your next blog post and find out what's new that all contributors have brought to KDE. Cheers :) |