| Summary: | blue border is not fully drawn when I hover a tooltip with playback controls | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Task Manager and Icons-Only Task Manager | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | 5.17.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/84182a55458802a2ab38ea58d640471b77b33ef3 | Version Fixed In: | 5.18.0 |
| Attachments: | screenshot | ||
It is fully drawn, but the playback controls are just drawn on top of it. I suppose we could move them in a bit. Git commit 84182a55458802a2ab38ea58d640471b77b33ef3 by Nate Graham.
Committed on 28/01/2020 at 21:07.
Pushed by ngraham into branch 'Plasma/5.18'.
[applets/Task Manager] Refine tooltip highlight effect
Summary:
This patch indents the window thumbnail and album art view by one pixel,
ensuring that the edges of the tooltip effect which is drawn under it are
never completely covered up and improving consistency between contents.
FIXED-IN: 5.18.0
Test Plan:
Just a window thumbnail:
Before: {F7912722}
After: {F7912726}
Player controls + icon:
Before: {F7980456}
After: {F7980448}
Player controls + window thumbnail:
Before: {F7980465}
After: {F7980472}
Player controls + album art
Before: {F7980454}
After: {F7980450}
Reviewers: #plasma, #vdg, filipf, ndavis
Reviewed By: #vdg, filipf, ndavis
Subscribers: trmdi, filipf, ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26739
M +9 -5 applets/taskmanager/package/contents/ui/ToolTipInstance.qml
https://commits.kde.org/plasma-desktop/84182a55458802a2ab38ea58d640471b77b33ef3
|
Created attachment 125205 [details] screenshot STEPS TO REPRODUCE 1. set global theme to breeze dark in system settings > global theme 2. play a music with Elisa or another player compatible with playback controls 3. hover over the tooltip of your player OBSERVED RESULT blue border of the hovering effect is not fully drawn. See the attached screenshot. EXPECTED RESULT blue border of the hovering effect is fully drawn SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.17.90 KDE Frameworks Version: 5.66.0 Qt Version: 5.14.0