Bug 416386

Summary: Stretched vertical line in Notifications widget with Oxygen Plasma theme
Product: [Plasma] plasmashell Reporter: varlesh <varlesh>
Component: NotificationsAssignee: Kai Uwe Broulik <kde>
Status: RESOLVED FIXED    
Severity: minor CC: kde, kde, mvourlakos, nate, plasma-bugs
Priority: NOR    
Version: 5.17.5   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.27.5
Sentry Crash Report:
Attachments: vertical-line
Oxygen plasma theme
fixed streched vertical-line (on Oxygen as example)

Description varlesh 2020-01-17 18:07:07 UTC
Created attachment 125200 [details]
vertical-line

Completed notifications used STRECHED vertical line on FullRepresentation.
Maybe it's good for Breeze plasma theme, but creates a limitation for other plasma themes.
Comment 1 varlesh 2020-01-17 18:20:23 UTC
vertical must strech to vertical, but not to horizontal.
Comment 2 David Edmundson 2020-01-17 18:21:08 UTC
what plasma theme is that?
Comment 3 varlesh 2020-01-17 18:22:51 UTC
https://github.com/varlesh/rounded
Comment 4 varlesh 2020-01-17 18:27:35 UTC
I'm use specific lines - with descending and ascending lines. But on notifications vertical-line streched to horizontal.
Comment 5 varlesh 2020-01-23 13:15:09 UTC
Created attachment 125320 [details]
Oxygen plasma theme

reproduced on any plasma theme. Oxygen, for example (attached)
Comment 6 varlesh 2020-01-23 13:32:35 UTC
problem will be fixed with remove duplicated width: units.iconSizes.small
on elementId: "vertical-line" in FullRepresentation
Comment 7 varlesh 2020-01-23 13:36:01 UTC
Created attachment 125321 [details]
fixed streched vertical-line (on Oxygen as example)
Comment 8 Christoph Feck 2020-02-04 00:16:59 UTC
Requested information was added with comment 5; changing status for inspection.
Comment 9 Nate Graham 2023-04-28 05:17:04 UTC
Can reproduce with the Oxygen theme. The issue here is that we're deliberately stretching the separator SVG in a way that looks fine the with Breeze theme, but doesn't look fine with Oxygen, and presumably also with other themes that have a separator style that isn't a simple line.

If we want a thick line, we should probably just use a QML Rectangle object.
Comment 10 Bug Janitor Service 2023-05-01 19:15:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2886
Comment 11 Nate Graham 2023-05-05 20:58:45 UTC
Git commit 591ce1f1f7e9f99d3854975e2a6d605ac4ecb44c by Nate Graham.
Committed on 05/05/2023 at 20:56.
Pushed by ngraham into branch 'master'.

applets/notification: fix history view vertical lines

Right now we use a thickened version of the Plasma theme's vertical line
SVG for the lines in grouped history items. However this is an abuse of
the SVGs, which were not necessarily designed to be thickened in that
way. The result looks fine for some themes where the SVG really is just
a plain vertical line, but does not look good for themes where the
graphic is fancier--for example, Oxygen.

Since the look we want here is just a thick line (AKA a rectangle),
let's just create one ourselves to avoid drama with the Plasma theme.
FIXED-IN: 5.27.5

M  +8    -5    applets/notifications/package/contents/ui/FullRepresentation.qml

https://invent.kde.org/plasma/plasma-workspace/commit/591ce1f1f7e9f99d3854975e2a6d605ac4ecb44c
Comment 12 Nate Graham 2023-05-05 21:02:38 UTC
Git commit b0056e32d0ade98051eeae9eae77175d402a3d22 by Nate Graham.
Committed on 05/05/2023 at 21:02.
Pushed by ngraham into branch 'Plasma/5.27'.

applets/notification: fix history view vertical lines

Right now we use a thickened version of the Plasma theme's vertical line
SVG for the lines in grouped history items. However this is an abuse of
the SVGs, which were not necessarily designed to be thickened in that
way. The result looks fine for some themes where the SVG really is just
a plain vertical line, but does not look good for themes where the
graphic is fancier--for example, Oxygen.

Since the look we want here is just a thick line (AKA a rectangle),
let's just create one ourselves to avoid drama with the Plasma theme.
FIXED-IN: 5.27.5


(cherry picked from commit 591ce1f1f7e9f99d3854975e2a6d605ac4ecb44c)

M  +8    -5    applets/notifications/package/contents/ui/FullRepresentation.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b0056e32d0ade98051eeae9eae77175d402a3d22