| Summary: | button to close GHNS window without label | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Jeremy Whiting <jpwhiting> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 288pat0tem, admin, kdelibs-bugs, leinir, nate |
| Priority: | NOR | ||
| Version: | 5.66.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=413434 | ||
| Latest Commit: | https://commits.kde.org/knewstuff/fd5b37818e6aa72fc149d9aec58511ca83e8a9d4 | Version Fixed In: | 5.67 |
| Sentry Crash Report: | |||
| Attachments: |
screenshot
Same on KDE neon testing |
||
This bug occurs if I set global theme to breeze and plasma style to breeze dark. Cannot reproduce. But we need to just delete this silly button and the row it sits on IMO... Created attachment 125633 [details]
Same on KDE neon testing
Just uploaded a patch to attempt to alleviate this issue: https://phabricator.kde.org/D27204 Git commit fd5b37818e6aa72fc149d9aec58511ca83e8a9d4 by Dan Leinir Turthra Jensen. Committed on 07/02/2020 at 13:53. Pushed by leinir into branch 'master'. Fix the KNSQuick Dialog's close title and basic layout Summary: This resolves several issues found in the KNSQuick Dialog component. Specifically it puts a background in the dialog (as a rectangle), since the QtQuick Dialogs base dialog lacks such a thing by default, and offers no background property to rectify it. It further changes the Close button from a custom one to using a default button provided by the various underlying systems. This is more fault proof than the previous incarnation, but requires that the escape button press is handled separately. Finally it sets a sensible default size (previously the dialog was made large by the layout, but as a side effect of the layouting now being done without a Layout (which we could, but which would make the code enormously convoluted for little gain), we can now set a set of implicit width and height on the content item, which results in both a sensible default size and a dialogue that will resize down the way one would expect it to). This could have been done as separate patches, but they're too intertwined for that to feel in any way reasonable to do... Related: bug 415606, bug 414682 Test Plan: The dialog with its new default size looks as follows: {F8089818} Reviewers: #frameworks, ngraham Reviewed By: ngraham Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D27204 M +19 -13 src/qtquick/qml/Dialog.qml https://commits.kde.org/knewstuff/fd5b37818e6aa72fc149d9aec58511ca83e8a9d4 |
Created attachment 125180 [details] screenshot STEPS TO REPRODUCE 1. open system settings > global themes 2. click on "Download new global themes" button 3. OBSERVED RESULT GHNS window opens and as we can see in the attached screenshot there is a button without label on bottom EXPECTED RESULT the button is labeled as "Close" SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.17.90 KDE Frameworks Version: 5.66.0 Qt Version: 5.14.0