Bug 416331

Summary: unnecessary horizontal scroll bar
Product: [Plasma] plasma-pa Reporter: Patrick Silva <bugseforuns>
Component: kcmAssignee: gvgeo <Gvgeo>
Severity: major CC: Gvgeo, kde, nate, notmart, plasma-bugs
Priority: HI Keywords: regression, usability
Version: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In: 5.18.3
Attachments: screenshot
system settings in side bar view
plasma-pa kcm opened via sound icon in systray

Description Patrick Silva 2020-01-16 11:47:54 UTC
Created attachment 125166 [details]

See the attached screenshot. Horizontal scroll bar is present despite there is nothing bo be scrolled.

1. open system settings > audio

no horizontal scroll bar

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.17.80
KDE Frameworks Version: 5.67.0
Qt Version: 5.13.2
Comment 1 Nate Graham 2020-01-16 17:02:15 UTC
Cannot reproduce; I see no scrollbar
Comment 2 Christoph Feck 2020-02-05 14:24:35 UTC
I see a scrollbar. Funny that resizing horizontally doesn't make it go away.
Comment 3 Nate Graham 2020-02-05 14:36:55 UTC
I can reproduce now too.
Comment 4 Patrick Silva 2020-02-13 12:38:17 UTC
Created attachment 125939 [details]
system settings in side bar view

No longer reproducible on Neon unstable.
But on Arch Linux the issue persists if system settings is set to side bar view and if plasma-pa kcm
is opened via sound icon in systray.

Operating System: Arch Linux 
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 5 Patrick Silva 2020-02-13 12:40:00 UTC
Created attachment 125940 [details]
plasma-pa kcm opened via sound icon in systray
Comment 6 David Edmundson 2020-02-14 00:25:17 UTC
You get the horizontal scrollbar if you have the vertical scrollbar.

When the scrollbar appears, the viewport gets smaller, but the contents are set to the width of the full view.

So you get the horizontal one to fit.

But changing the problem, do we even need a scrollview inside the tab? The container adds one anyway
Comment 7 Nate Graham 2020-02-14 00:33:17 UTC
Comment 8 gvgeo 2020-02-22 14:29:09 UTC
Does not remove the scrollbar.
Comment 9 gvgeo 2020-03-03 10:41:13 UTC
Git commit 552b0384ffd205a148df62239058cee9a4a6702e by George Vogiatzis.
Committed on 03/03/2020 at 10:37.
Pushed by gvgeo into branch 'Plasma/5.18'.

[KCM]Fix content below scrollbars

Set content to use available space.
Make scrollbars touch the side of the frame.
Fit speaker test grid inside the scrollview area.
Fix advanced content layout.
Make Header always fit inside the scrollview area.
Related: bug 417447

Test Plan:
Open audio settings from kickoff.



Reviewers: #plasma, #vdg, drosca, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27577

M  +188  -189  src/kcm/package/contents/ui/Advanced.qml
M  +65   -66   src/kcm/package/contents/ui/Applications.qml
M  +41   -42   src/kcm/package/contents/ui/Devices.qml
M  +6    -1    src/kcm/package/contents/ui/Header.qml
M  +1    -0    src/kcm/package/contents/ui/main.qml