| Summary: | 7.0.0-beta2 crash when closing Geolocation Editor | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | hmueller <kde> |
| Component: | Geolocation-Bookmarks | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version First Reported In: | 7.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | macOS (DMG) | ||
| OS: | macOS | ||
| Latest Commit: | https://invent.kde.org/kde/digikam/commit/21ac95e61167bcf705b46ba6f926e184f69608ae | Version Fixed/Implemented In: | 7.0.0 |
| Sentry Crash Report: | |||
| Attachments: |
Crash report
Crash report 16.01.2020 |
||
I havn't seen this crash on Win10 with latest build, so it might be Mac specific. If i remeber, Maik has touch something in BookmarkManager while Christmas holidays, but i don't remember what exactly... MacOs is more sensible than Linux and Windows as i can see. Gilles Caulier We delete the bookmark nodes to prevent a memory leak. It is possible that we delete them too early because the view model accesses them again. A QSharedPointer is not really possible because the bookmark nodes are automatically deleted when the pointer is deleted. I'll watch it tonight. Maik Git commit 537345be7223394c47c7b41629b2997f706e3bd3 by Maik Qualmann. Committed on 15/01/2020 at 21:47. Pushed by mqualmann into branch 'master'. try to fix crash under OSX M +0 -1 core/dplugins/generic/metadata/geolocationedit/dialog/geolocationedit.cpp M +2 -1 core/utilities/geolocation/geoiface/bookmark/gpsbookmarkowner.cpp https://invent.kde.org/kde/digikam/commit/537345be7223394c47c7b41629b2997f706e3bd3 Created attachment 125167 [details]
Crash report 16.01.2020
Comment on attachment 125167 [details]
Crash report 16.01.2020
Tried the new nightly build digiKam-7.0.0-beta2-20200116T073708-MacOS-x86-64. No success. Sorry.
Thanks, the backtrace is good, next try tonight. Maik Git commit 21ac95e61167bcf705b46ba6f926e184f69608ae by Maik Qualmann. Committed on 16/01/2020 at 22:05. Pushed by mqualmann into branch 'master'. fix delete order from the bookmark nodes FIXED-IN: 7.0.0 M +2 -2 NEWS M +4 -3 core/utilities/geolocation/geoiface/bookmark/bookmarknode.cpp https://invent.kde.org/kde/digikam/commit/21ac95e61167bcf705b46ba6f926e184f69608ae This crash was not specific to OSX and could also be reproduced under Linux, depending on the tree structure of the bookmarks. Maik Unfortunately there was no new build tonight at https://files.kde.org/digikam/ So I can not test it right away. Wait a little bit, compilation is under progress. It must be published in one hour Gilles Caulier Perfect, the patch works. No crash any more. Thanks for this very quick solution! Thanks for the feedback. Great to see the problem solved under MacOS |
Created attachment 125146 [details] Crash report This bug was introduced after digiKam-7.0.0-beta2-20200104T124857-MacOS-x86-64. Seen since digiKam-7.0.0-beta2-20200112T104105-MacOS-x86-64 as well as in lastest build digiKam-7.0.0-beta2-20200115T070550-MacOS-x86-64. digiKam crahes when closing the Geolocation Editor (no whether what was done in this dialog).