| Summary: | Use prlimit64 in VG_(getrlimit) and VG_(setrlimit) | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Stefan Maksimovic <stefan.maksimovic> |
| Component: | general | Assignee: | Julian Seward <jseward> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mark, mips32r2 |
| Priority: | NOR | ||
| Version First Reported In: | 3.15 SVN | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | patch | ||
Did anyone have a chance to take a look at this in the meantime? Anyone against this patch? This looks correct. Whenever possible we should use prlimit64. |
Created attachment 125143 [details] patch Amend the recent update to VG_(getrlimit) and VG_(setrlimit) [get|set]rlimit system calls are becoming deprecated. Coregrind should use prlimit64 as the first candidate in order to achieve "rlimit" functionality. There are also systems that do not even support older "rlimits". Modify the previously added support VG_(getrlimit) and VG_(setrlimit) using __NR_prlimit64 by making it similar to the glibc implementation. This change has been tested on x86 and mips and we would like feedback on how it behaves on other architectures/systems.