Summary: | Zooming out with CTRL+mousewheel does not work correctly anymore | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | John van Spaandonk <jwork123nl> |
Component: | general | Assignee: | Okular developers <okular-devel> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | CC: | aacid, nate, oliver.sander, yurchor |
Priority: | NOR | ||
Version: | 1.9.1 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
John van Spaandonk
2020-01-14 08:47:30 UTC
I cannot reproduce this with Okular from the current git master. Zoom with ctrl+mouse wheel seems to work as expected. Can you tell if the "View -> Trim view -> Trim margins" menu item is selected? Thanks in advance for your answer. waiting for the trim margins answer Works for me too with git master when not using Trim Margins. On 2020-01-14 18:17, Yuri Chornoivan wrote: > https://bugs.kde.org/show_bug.cgi?id=416229 > > Yuri Chornoivan <yurchor@ukr.net> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |yurchor@ukr.net > > --- Comment #2 from Yuri Chornoivan <yurchor@ukr.net> --- > Can you tell if the "View -> Trim view -> Trim margins" menu item is selected? > > Thanks in advance for your answer. > Yes indeed, If I deselect "Trim Margins" and also do not select "Trim to selection" it works as expected. I will close this report then. In all honesty, while I now understand the behavior, my honest expectation was that the keyboard controls for zoom would always zoom, overriding / disabling any trim views. But I understand why you see the keyboard controls as mirroring the behavior of the "zoom level" window, and not overriding other settings. ps. I am very happy that you react instantaneously to this bug report. (In reply to Yuri Chornoivan from comment #2) > Can you tell if the "View -> Trim view -> Trim margins" menu item is > selected? > > Thanks in advance for your answer. [this reply might be double with another reply I did via email but I changed it a bit] Yes indeed, If I deselect "Trim Margins" and also do not select "Trim to selection" it works as expected. Please close this bug report if you do not agree to the suggestion below. I still think this is a usability issue. While I now understand the behavior, my honest expectation was that the keyboard controls for zoom would always mirror the behavior of the "zoom level" box, so overriding any trim views. I think it makes perfect sense if the keyboard controls just mirror making a selection in the "zoom level" window. Therefore they should have the same freedom in entering another zoom level, irrespective of the selected "zoom to" option. ps. I am very happy that you react instantaneously to this bug report. I guess then we can mark it as duplicate. At some point we should either remove trim margins or someone should fix all its bugs *** This bug has been marked as a duplicate of bug 342003 *** > At some point we should either remove trim margins or someone should fix all its bugs
BTW: Where is the code that determines what the margin is?
(In reply to Oliver Sander from comment #8) > > At some point we should either remove trim margins or someone should fix all its bugs > > BTW: Where is the code that determines what the margin is? Utils::imageBoundingBox But I don't think there's any bug there, that code is relatively simple. The code for this bug is probably somewhere else that gets confused when calculating the zoom. There's also lots of other bugs related to handling of size of pages since they are no longer the size we expect them to be once you trim the margins. |