| Summary: | It is possible to place | into "Are you sure you want to open X items?" warning | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kwidgetsaddons | Reporter: | Lucia Mrenica <lucia.mrenica> |
| Component: | general | Assignee: | Christoph Feck <cfeck> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | kdelibs-bugs-null, kfm-devel, lucia.mrenica, nate |
| Priority: | NOR | ||
| Version First Reported In: | 5.66.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwidgetsaddons/945f1849cc246107d20d92768b67a2010f2fae39 | Version Fixed In: | 5.67 |
| Sentry Crash Report: | |||
|
Description
Lucia Mrenica
2020-01-13 13:19:11 UTC
Might be intentional to be able to mark text for copying (Shift+Cursor). But for that you need to click there anyway, and if you have to click you can just highlight the text with mouse like anywhere else without a need for the thing |. I didn't check, but it might be possible to Tab into that text widget. The I-beam makes the text keyboard-selectable as well. But I agree, that might be overkill. It's possible to make it only mouse-selectable, which we did for the labels in the Information panel because of this very complaint. Actually it is in Dolphin after all. Hah, it's actually in all the message boxes, which live in kwidgetaddons. Patch: https://phabricator.kde.org/D26649 Git commit 945f1849cc246107d20d92768b67a2010f2fae39 by Nate Graham.
Committed on 14/01/2020 at 18:40.
Pushed by ngraham into branch 'master'.
[KMessageBox] Only allow selecting text in the dialog box using the mouse
Summary:
Right now, when you select text in the dialog box, an insertion point appears. It never
disappears. This looks odd: {F7882083}
The insertion point allows you to navigate the text using the keyboard. But this is kind
of pointless since you have to use the mouse to make the insertion point appear in the
text in the first place, so you might as well just use the mouse to make the selection.
This patch makes the text only mouse-selectable. Dolphin recently did the same thing
for its Information Panel labels in D25241 for the same reason.
FIXED-IN: 5.67
Test Plan:
Try to open 6 items at once in Dolphin and click-and-drag in the message box text.
Test is still selectable, but an insertion point is no longer created that cannot be
removed.
Reviewers: dfaure, #frameworks, #vdg, ndavis
Reviewed By: #vdg, ndavis
Subscribers: broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D26649
M +2 -2 src/kmessagebox.cpp
https://commits.kde.org/kwidgetsaddons/945f1849cc246107d20d92768b67a2010f2fae39
|