Bug 416144

Summary: Build failure with QT 5.14
Product: [Applications] Elisa Reporter: Edward Kigwana <ekigwana>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED FIXED    
Severity: normal CC: lucia.mrenica, nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/kde/elisa/commit/80901e98b06f35e0338b43a1b91f3591bee604d6 Version Fixed/Implemented In:
Sentry Crash Report:

Description Edward Kigwana 2020-01-12 01:24:59 UTC 
SUMMARY
Build failure against QT 5.14

STEPS TO REPRODUCE
1. Install QT 5.14
2. Build

OBSERVED RESULT
Failure
/var/tmp/portage/media-sound/elisa-9999/work/elisa-9999/src/audiowrapper_qtmultimedia.cpp: In member function ‘QUrl AudioWrapper::source() const’:
/var/tmp/portage/media-sound/elisa-9999/work/elisa-9999/src/audiowrapper_qtmultimedia.cpp:78:31: error: ‘class QMediaContent’ has no member named ‘canonicalUrl’
   78 |     return d->mPlayer.media().canonicalUrl();

EXPECTED RESULT

Buiild. I got it to build by changing
   d->mPlayer.media().canonicalUrl();
to
   d->mPlayer.media().request().url();

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 5.14

ADDITIONAL INFORMATION
Comment 1 Lucia Mrenica 2020-01-12 14:51:36 UTC 
I am on Arch Linux and it builds just fine with Qt5.14. What version did you try? git-master?
Comment 2 Edward Kigwana 2020-01-12 21:54:33 UTC 
I am building out of master which sets KF_DISABLE_DEPRECATED_BEFORE_AND_AT.
According to https://github.com/qt/qtmultimedia/blob/5.14.0/src/multimedia/playback/qmediacontent.h There is no issue at all. This bug then applies for the current KF6 pursuits
Comment 3 Matthieu Gallien 2020-01-13 07:54:25 UTC 
Thanks, it is a good idea to fix that as soon as possible. Would you like to work on a patch?
https://community.kde.org/Get_Involved has a lot of info. Elisa is using invent.kde.org
Comment 4 Edward Kigwana 2020-01-13 15:57:27 UTC 
https://invent.kde.org/kde/elisa/merge_requests/65
Comment 5 Matthieu Gallien 2020-01-13 20:54:20 UTC 
Git commit 80901e98b06f35e0338b43a1b91f3591bee604d6 by Matthieu Gallien, on behalf of Edward Kigwana.
Committed on 13/01/2020 at 20:53.
Pushed by mgallien into branch 'master'.

Migrate from deprecated media content URL API

New interface available starting with QT 5.14.0.

Signed-off-by: Edward Kigwana <ekigwana@gmail.com>

(cherry picked from commit 0adb96e0ee4cebbf35289024a4a56c563ac85b92)

M  +4    -0    src/audiowrapper_qtmultimedia.cpp

https://invent.kde.org/kde/elisa/commit/80901e98b06f35e0338b43a1b91f3591bee604d6