Bug 416018

Check the Tag tab, you have probably also selected something there, these will be added to the search. Definitely only the albums that are selected will be scanned.

Maik

No: same result if no tags are selected

Git commit b904cf973b004d0f483efa63c4e8f6676068e7db by Maik Qualmann.
Committed on 08/01/2020 at 21:06.
Pushed by mqualmann into branch 'master'.

disable "Clear unconfirmed results and rescan" option
Because face detection and recognition are currently deactivated

M  +10   -1    core/utilities/facemanagement/widgets/facescanwidget.cpp

https://invent.kde.org/kde/digikam/commit/b904cf973b004d0f483efa63c4e8f6676068e7db

(In reply to Nicofo from comment #2)
> No: same result if no tags are selected

We have this reported as an error several times. I have never been able to reproduce it here. Only the selected albums are scanned. I've debugged the code many times, I can't imagine digiKam making a mistake here.

Maik

(In reply to Maik Qualmann from comment #4)
> We have this reported as an error several times. I have never been able to
> reproduce it here. Only the selected albums are scanned. I've debugged the
> code many times, I can't imagine digiKam making a mistake here.

Where is the mistake then ? ... How can I help ?

I made new tests: in "Search in":

1) No Album selected, No Tag selected -> as said before, the entire collection seems to be scanned (this is NOT as expected: I expect nothing is scanned).

2) No Album selected, One Tag selected -> only pictures tagged with that people are scanned (don't know if it is as expected, because for me Tags should not be related to face detection)
Note that I don't understand why it is possible to restrict the face detection to some face Tags ? Face detection should be made possible for specified Albums ("Search in" > "Albums" tab) but NOT for specified people ("Search in" > "Tags" tab) because this is only face detection, not face recognition. In the detection phase, you obviously do not know if it corresponds to some Tag people.

Sorry but for me the UI for face detection/recognition is very confusing (or buggy?).

1) Is an intended behavior that applies everywhere in digiKam, there is no selection, the whole collection is used. This behavior also exists in the Icon View, if no selection is made, the entire items is taken over when called up by a tool.

2) The tags are not only limited to person tags. For example, by selecting the "France" tag from a trip. This will only scan these images.

Maik

When choosing just one tag, the entire collection seems to be scanned, so I look at it.

Maik

Git commit 9d60f152e77b5201ce6bf23473684a32444bf586 by Maik Qualmann.
Committed on 09/01/2020 at 17:48.
Pushed by mqualmann into branch 'master'.

fix wrong item selection for face recognition
Related: bug 416028, bug 415782, bug 415867, bug 415895

M  +3    -1    NEWS
M  +0    -29   core/utilities/facemanagement/widgets/facescanwidget.cpp
M  +15   -0    core/utilities/maintenance/facesdetector.cpp

https://invent.kde.org/kde/digikam/commit/9d60f152e77b5201ce6bf23473684a32444bf586

Thank you for your quick reaction and look in the code ;)
I'll test when new appimage available.

Still can you explain exactly what I need to do to scan for faces (face detection) a specific Album (and only that album) ?
- In "Search in" > Albums: I need to select the desired Album (obviously !)
- In "Search in" > Tags: what do I need to select ?
  - If I select nothing ==> (1) what will be scanned ??
(in comment #6 you say: "there is no selection, the whole collection is used"  ==> not what I want)
  - If I select everything ==> (2) what will be scanned ??
(I suppose e.g. pictures with "France" tag will be scanned, even if not part of the selected Album ? ==> not what I want)

In other words, how does digikam manage the selections in "Albums" and in "Tags" tabs ? ==> (3) Does it use an AND or an OR (pictures to be scanned must match ALL or ANY criteria) ??

Last question: is the selection made in "Search in" > "Tags" used the same way by digikam for face detection and face recognition ?
- for face detection, according to your comment #6, it is used to scan e.g. all pictures with the tag "France" (so independently of the Albums selection). ==> (4) is it correct ??
- for face recognition: I think that it will rather try to recognize only people whose people tag is selected. So different behavior as for face detection. ==> (5) is it correct ??

Can you please answer to the 5 questions above "==> (x) xx ??"
Sorry if this may be obvious for you, but I'm still a bit confused ;)
Thanks in advance

Don't make it too complicated. ((:-)) If you only want to scan an album, select it in the Album tab. You don't select anything in the Tag tab.

You can also use the right context menu in the Album view to scan just one album or image.

Maik

Thank you, I have tested with appimage digikam-7.0.0-beta2-20200112T071518-x86-64 and no more problem.

I'll answer to myself for my questions in comment #9:
(3) If Albums AND Tags are selected in "Search in", the search is done in both Albums and Tags matching the selection (so it's an "OR").
    If ONLY Albums or Tags are selected, the search is done on the selected Albums or Tags (normal ! And no bug anymore for me)
(5) "Search in" is now disabled for face recognition. Good, less confusing if not used. Anyway could be some improvement done here: allow to select faces so that the face recognition will only recognize specific people (this just an idea, not related to this bug).

Finally, my last source of confusion is that when nothing is selected in Albums AND Tags, digikam makes the detection on the entire collection. But this is not too annoying as no one should click on "Scan collection for faces" and expect that nothing happens ;-)