Bug 416010

Summary:	Missing detection for llvm *git version
Product:	[Applications] kdevelop	Reporter:	Gustaw Smolarczyk <wielkiegie>
Component:	general	Assignee:	kdevelop-bugs-null
Status:	RESOLVED FIXED
Severity:	normal	CC:	slavko, wielkiegie
Priority:	NOR
Version First Reported In:	5.4.5
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/kdevelop/commit/23c7fec54cc273312a195361cf1add20ab18f3a4	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch suggestion

Description Gustaw Smolarczyk 2020-01-08 17:52:33 UTC

llvm built from master on gentoo is checked out using git instead of svn (the reason might also be that LLVM project is in the process of moving to git completely [1]). Because of that the llvm-config returns something like this:

$ llvm-config --version
10.0.0git

A year ago a patch [2] added support for the svn suffix, it would be nice to have support for the git suffix as well.

Right now instead the llvm is not detected correctly:

-- Found LLVM (version: 10.0.0git): (using /usr/lib/llvm/10/bin/llvm-config)
--   Include dirs:   /usr/lib64/llvm/10/include
--   LLVM libraries: /usr/lib64/llvm/10/lib64/libLLVM-10git.so
-- Found LLVM (version: 10.0.0git): (using /usr/lib/llvm/10/bin/llvm-config)
--   Include dirs:   /usr/lib64/llvm/10/include
--   LLVM libraries: /usr/lib64/llvm/10/lib64/libLLVM-10git.so
-- Found LLVM (version: 10.0.0git): (using /usr/lib/llvm/10/bin/llvm-config)
--   Include dirs:   /usr/lib64/llvm/10/include
--   LLVM libraries: /usr/lib64/llvm/10/lib64/libLLVM-10git.so
-- Found LLVM (version: 10.0.0git): (using /usr/lib/llvm/10/bin/llvm-config)
--   Include dirs:   /usr/lib64/llvm/10/include
--   LLVM libraries: /usr/lib64/llvm/10/lib64/libLLVM-10git.so
-- Found LLVM (version: 10.0.0git): (using /usr/lib/llvm/10/bin/llvm-config)
--   Include dirs:   /usr/lib64/llvm/10/include
--   LLVM libraries: /usr/lib64/llvm/10/lib64/libLLVM-10git.so
-- Found LLVM (version: 10.0.0git): (using /usr/lib/llvm/10/bin/llvm-config)
--   Include dirs:   /usr/lib64/llvm/10/include
--   LLVM libraries: /usr/lib64/llvm/10/lib64/libLLVM-10git.so
-- Found LLVM (version: 10.0.0git): (using /usr/lib/llvm/10/bin/llvm-config)
--   Include dirs:   /usr/lib64/llvm/10/include
--   LLVM libraries: /usr/lib64/llvm/10/lib64/libLLVM-10git.so
-- Found LLVM (version: 10.0.0git): (using /usr/lib/llvm/10/bin/llvm-config)
--   Include dirs:   /usr/lib64/llvm/10/include
--   LLVM libraries: /usr/lib64/llvm/10/lib64/libLLVM-10git.so
CMake Error at cmake/modules/FindClang.cmake:116 (message):
  Could not find Clang builtin directory
Call Stack (most recent call first):
  plugins/CMakeLists.txt:43 (find_package)

[1] http://blog.llvm.org/2019/08/the-llvm-project-is-moving-to-github.html
[2] https://phabricator.kde.org/D15998

Comment 1 slavko 2020-01-20 10:10:29 UTC

Created attachment 125258 [details]
Patch suggestion

Comment 2 Milian Wolff 2020-01-22 09:24:10 UTC

Git commit 23c7fec54cc273312a195361cf1add20ab18f3a4 by Milian Wolff.
Committed on 22/01/2020 at 09:24.
Pushed by mwolff into branch '5.4'.

Fix build against clang built from git

M  +2    -0    cmake/modules/FindClang.cmake

https://invent.kde.org/kde/kdevelop/commit/23c7fec54cc273312a195361cf1add20ab18f3a4

Comment 3 Milian Wolff 2020-01-22 09:30:18 UTC

thank you!