Bug 415984

Summary:	Kickoff uses dialogs/background.svgz instead of dialogs/kickoff.svgz
Product:	[Plasma] plasmashell	Reporter:	cam <camabyss>
Component:	Application Launcher (Kickoff) widget	Assignee:	David Edmundson <kde>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	nate, plasma-bugs-null
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Kubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description cam 2020-01-08 00:52:35 UTC

SUMMARY
Kickoff uses dialogs/background.svgz instead of dialogs/kickoff.svgz when themeing in ~/.local/share/plasma/desktoptheme/

STEPS TO REPRODUCE
1. Install a plasma theme with separate dialog svgz, for instance Ghost https://store.kde.org/p/998879/
2. Equip the theme, then open kickoff
3. Notice kickoff is not using the kickoff.svg(z) file

OBSERVED RESULT
Kickoff is styled with dialogs/background.svg(z)


EXPECTED RESULT
Kickoff should be styled with dialogs/kickoff.svg(z) if it exists


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 19.10
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.12.4

ADDITIONAL INFORMATION
Applies to all themes I've tried, notice the theme I lined to has the "frame with a prefix of 'plain'" as required in the docs.
Is something missing here? Has it been renamed?

Comment 1 David Edmundson 2020-01-09 00:29:56 UTC

>Is something missing here? Has it been renamed?

No, it's just a subtle behaviour change we've had since 5.0.

I'm not sure if it's worth fixing as it's quite a feature creep to have themes do something on a per-widget basis and this is the first report we've got since 5.0

Comment 2 cam 2020-01-09 19:04:16 UTC

(In reply to David Edmundson from comment #1)

But it means the start menu has to be boring because it uses the same style as a notification, it also means that the styles hardly fit since they are such different sizes. Also complex notification styles tend to have a lot of stuff over to the left & bottom which is completely clipped in the start menu.

> it's quite a feature creep
But you've removed a feature?

> to have themes do something on a per-widget basis
There's literally a folder called "widgets", why not have widgets/kickoff.svg(z) ?

> I'm not sure if it's worth fixing
I do. If I pull the /usr/share/plasma/plasmoids/org.kde.plasma.kickoff/ files from < 5.0 will it get it working again? I have a feeling the file auto-detection is happening somewhere else...

Comment 3 cam 2020-01-09 19:16:45 UTC

I'm also now seeing that tooltips are styled with widgets/tooltip.svgz but are pulling shadows from widgets/background.svgz

Is THIS a real bug or am I just not getting that customizability is a feature creep?

Comment 4 cam 2020-01-09 19:17:41 UTC

Sorry that's dialogs/background not widgets/background

Comment 5 Nate Graham 2021-01-07 19:09:10 UTC

I agree with David. kickoff.svg is basically considered deprecated.

Sorry. :)

Comment 6 cam 2021-01-24 03:51:26 UTC

Yes, I can see it's deprecated, this is a massive problem as the application menu and dialog boxes are completely unrelated.
Please fix :)