Bug 415917

I can reproduce this.

It seems to be caused by this line: https://phabricator.kde.org/source/plasma-desktop/browse/master/containments/desktop/package/contents/ui/FolderView.qml$165

Git commit fbb2be9aad196d92ca1a7adcc8afa8b63ba83659 by Tranter Madi.
Committed on 13/01/2020 at 12:34.
Pushed by trmdi into branch 'master'.

Add KIO::DropJobFlag to allow manually showing the menu

Summary:
This patch allows the application to manually popup the menu by using the `KIO::ShowMenuManually` flag with the `DropJob::showMenu()` method.

Test Plan: Can't reproduce the bug with this patch.

Reviewers: #frameworks, davidedmundson, elvisangelaccio, mart, dfaure

Reviewed By: dfaure

Subscribers: ngraham, broulik, anthonyfieroni, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D26484

M  +29   -5    src/widgets/dropjob.cpp
M  +37   -0    src/widgets/dropjob.h

https://commits.kde.org/kio/fbb2be9aad196d92ca1a7adcc8afa8b63ba83659

Tranter, could you please add a clarification which issue remains after the recent commit? https://phabricator.kde.org/D26691 looks related, but only seems an optimization?

(In reply to Christoph Feck from comment #4)
> Tranter, could you please add a clarification which issue remains after the
> recent commit? https://phabricator.kde.org/D26691 looks related, but only
> seems an optimization?

Yes, the above commit only add the new method in KIO::DropJob.
Plasma need to make use of it to fix this bug but it hasn't yet.

Maybe I shouldn't have added the BUG: line in the patch above. Sorry.

Thanks for the clarification. You can use CCBUG: ###### in commit messages to reference a bug without closing it.

Git commit f8be3ea7102fbd584da1a39f5285ca72b5e69afa by Tranter Madi.
Committed on 04/02/2020 at 05:54.
Pushed by trmdi into branch 'master'.

Optimize code when dropping files into the desktop

Summary:
Currently, when you have the desktop in the Desktop layout, if you drop 10 jpg files into the desktop, it creates 10 menus at the same position.
When you have the desktop in the Folder layout, if you drop 10 jpg files into the desktop, it calls `KIO::setApplicationActions()` 10 times.

What does this improve?

- Do not create KIO::MimetypeJob for each file
- Do not call `DropJob::setApplicationActions()` too many times/ create too many menus for each file.

My idea is that, when you drop files into the desktop:
- If they have the same `mimetype` -> we add actions support this `mimetype`.
- If not -> we only show the action from `KIO::DropJob` and only actions support different `mimetypes` at the same time like `Add icon`...

**Require:** D26484

Reviewers: #plasma, mart, broulik, #vdg, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D26691

M  +95   -152  src/scriptengines/qml/plasmoid/containmentinterface.cpp
M  +2    -4    src/scriptengines/qml/plasmoid/containmentinterface.h
A  +110  -0    src/scriptengines/qml/plasmoid/dropmenu.cpp     [License: LGPL (v2+)]
A  +66   -0    src/scriptengines/qml/plasmoid/dropmenu.h     [License: LGPL (v2+)]

https://commits.kde.org/plasma-framework/f8be3ea7102fbd584da1a39f5285ca72b5e69afa

Git commit 36e918b0978076359c17c70c136bd27862db9d63 by Tranter Madi.
Committed on 04/02/2020 at 05:55.
Pushed by trmdi into branch 'master'.

Delay popup when dropping things into containments

Summary:
Depend: D26691

Test Plan: Drop files into desktop folder layout/folder widget, the menu is shown correctly in all cases.

Reviewers: #plasma, davidedmundson, broulik, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26514

M  +2    -2    containments/desktop/package/contents/ui/FolderView.qml
M  +3    -2    containments/desktop/plugins/folder/foldermodel.cpp
M  +1    -1    containments/desktop/plugins/folder/foldermodel.h

https://commits.kde.org/plasma-desktop/36e918b0978076359c17c70c136bd27862db9d63