Bug 415817

Summary:	"Set Coordinates Manually..." always treats input as J2000 even if Jnow is selected.
Product:	[Applications] kstars	Reporter:	Phil Stuart <a>
Component:	general	Assignee:	Jasem Mutlaq <mutlaqja>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	3.3.9
Target Milestone:	---
Platform:	macOS (DMG)
OS:	macOS
Latest Commit:	https://commits.kde.org/kstars/9ea44f783fcafe1ec16152bc45d564b2531f31a0	Version Fixed/Implemented In:	3.4.0
Sentry Crash Report:

Description Phil Stuart 2020-01-02 19:37:22 UTC

SUMMARY

The option to "Set Coordinates Manually..." has the option to input RA and Dec as either J2000 or Jnow.  The buttons have no effect, though.  The conversion from J2000 to Jnow is always applied, even if Jnow coordinates were entered and the Jnow button was clicked.  This causes the wrong location to be used if Jnow coordinates are entered.


STEPS TO REPRODUCE
1. Pointing -> Set Coordinates Manually...
2. In the dialog that pops up, the default is Jnow coordinates.  Leave it set to Jnow and enter Jnow coordinates for Pollux: RA=07h 46m 31.63s, Dec=27:58:32.82
3. Leave the option set to Jnow and hit "OK".

OBSERVED RESULT
The sky view will change but Pollux will not be in the center.  The error is equal to the difference between Jnow and J2000.

EXPECTED RESULT
The sky view will change and Pollux will be in the center of the view.

The test can be redone by leaving the button set at Jnow but inputting the J2000 coordinates of Pollux: RA=07h 45m 19.38s, Dec=28:01:34.72.  Leave it set for Jnow and hit "OK".  The sky view will now center on Pollux even though the wrong datum was used.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 10.14.6
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Jasem Mutlaq 2020-01-03 07:19:31 UTC

Git commit 9ea44f783fcafe1ec16152bc45d564b2531f31a0 by Jasem Mutlaq.
Committed on 03/01/2020 at 07:18.
Pushed by mutlaqja into branch 'master'.

Explicitly treat JNow and J2000 differently when setting the sky point RA and DE components
FIXED-IN:3.4.0

M  +17   -4    kstars/dialogs/focusdialog.cpp

https://commits.kde.org/kstars/9ea44f783fcafe1ec16152bc45d564b2531f31a0