Bug 415816

Summary:	While renaming an item, dragging outside of the text area draws a selection marquee that allows selecting other items
Product:	[Plasma] plasmashell	Reporter:	DeKay <darrylkacher>
Component:	Desktop icons & Folder View widget	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.17.4
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-desktop/d4d39892d62e6d551a172fae0f5845fe2eea6396	Version Fixed/Implemented In:	5.18.0
Sentry Crash Report:

Description DeKay 2020-01-02 19:24:57 UTC

SUMMARY

When renaming a file on the desktop, I can select both the text of the filename and other file icons at the same time.


STEPS TO REPRODUCE
1. Start with a column of icons on the plasma desktop.  Pick a file somewhere in the middle and use F2 to start renaming the file.  
2. With the mouse, select the text of the filename by clicking and dragging.  Keeping the left mouse button down, extend the selection out past the filename field and up to other icons.

OBSERVED RESULT
Both the filename text *and* other icons on the desktop are selected at the same time.  This is unexpected behavior.  For example, if I selected Delete, would it delete the text and the selected files?


EXPECTED RESULT
When renaming a file inline, the selection should be confined to the filename field only and not extended to other files on the desktop.  Note that this works properly when renaming a file in Dolphin's various views, so the problem seems to be specific with plasma desktop.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
(available in About System)
KDE Plasma Version: 5.17.4
KDE Frameworks Version:  KDE 5.65.0
Qt Version: 5.13.2

Comment 1 Nate Graham 2020-01-07 00:03:10 UTC

Wow that's wild! Can confirm.

Comment 2 Nate Graham 2020-01-07 00:21:20 UTC

This patch should fix it: https://phabricator.kde.org/D26482

Comment 3 Nate Graham 2020-01-08 00:04:22 UTC

Git commit d4d39892d62e6d551a172fae0f5845fe2eea6396 by Nate Graham.
Committed on 08/01/2020 at 00:04.
Pushed by ngraham into branch 'master'.

[Folder view] Don't create a rubberband when dragging during a rename

Summary:
FIXED-IN: 5.18.0

Test Plan:
Rename an item on the desktop
Start a drag within the text area
While dragging, move the cursor out of the text area
Other filed no longer get selected by a rubberband

Reviewers: hein, #plasma

Reviewed By: hein, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26482

M  +2    -2    containments/desktop/package/contents/ui/FolderView.qml

https://commits.kde.org/plasma-desktop/d4d39892d62e6d551a172fae0f5845fe2eea6396

Comment 4 DeKay 2020-01-11 22:18:05 UTC

WOW!  Thanks for getting this fixed so quickly!  BTW Nate, I very much enjoy your weekly updates.  Keep them up  :-)

Comment 5 Nate Graham 2020-01-11 22:25:41 UTC

Thanks, I plan to. :)