Summary: | VCS plugin function calls redundant | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Nikolai Krasheninnikov <nkrasheninnikov> |
Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | elvis.angelaccio, kfm-devel |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/dolphin/d0cbcf9718bb5192738ea9f5a5a3d6c4f9f7dcef | Version Fixed In: | 20.04 |
Sentry Crash Report: |
Description
Nikolai Krasheninnikov
2019-12-30 08:04:42 UTC
Patches welcome ;) Addition on #4: as it turns out KVersionControlPlugin::itemVersion() got called by VCS plugin itself on the context menu creation so its ok. Git commit 305085b58143c431d9abb7bd8dcb2f0954df725a by Elvis Angelaccio, on behalf of Nikolai Krasheninnikov. Committed on 26/01/2020 at 16:09. Pushed by elvisangelaccio into branch 'master'. Fixes multiple VCS plugin calls on single directory update. Summary: Fixes multiple VCS plugin beginRetrival()/endRetrival()/itemVersion() calls on single directory update. When VCS pluging finished gathering directory information VersionControlObserver::slotThreadFinished() calls KFileItemModel::setData() on each entry with appropriate item VCS information. This in turn emits KFileItemModel::itemsChanged() which is connected with VersionControlObserver::delayedDirectoryVerification() which is starting to gather VCS directory information again. This commits breaks the vicious circle. FIXED-IN: 20.04.0 Reviewers: #dolphin, meven, ngraham, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26721 M +14 -2 src/views/versioncontrol/versioncontrolobserver.cpp M +7 -0 src/views/versioncontrol/versioncontrolobserver.h https://commits.kde.org/dolphin/305085b58143c431d9abb7bd8dcb2f0954df725a Git commit d0cbcf9718bb5192738ea9f5a5a3d6c4f9f7dcef by Nate Graham, on behalf of Nikolai Krasheninnikov. Committed on 18/02/2020 at 21:55. Pushed by ngraham into branch 'master'. Fixes multiple KVersionControlPlugin::fileName() calls on entering or updating directory. Summary: FIXED-IN: 20.04 On each VCS plugin creation corresponding file name is saved (cached) so when we search which VCS plugin is appropriate for current directory we don't need to call KVersionControlPlugin::fileName() again. Reviewers: #dolphin, meven, elvisangelaccio, ngraham Reviewed By: #dolphin, meven, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26962 M +6 -6 src/views/versioncontrol/versioncontrolobserver.cpp M +2 -1 src/views/versioncontrol/versioncontrolobserver.h https://commits.kde.org/dolphin/d0cbcf9718bb5192738ea9f5a5a3d6c4f9f7dcef |